Skip to content

Conversation

@And1sS
Copy link
Collaborator

@And1sS And1sS commented Jul 8, 2025

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

Added new property to enable round-robin inet address selection of the ip address to use.

🧠 Rationale behind the change

This change will add new toggle to control ip address selection to not hit same ip and evenly distribute load.

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

Doesn't need tests since its just vertx library feature toggle.

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@And1sS And1sS requested a review from osulzhenko July 8, 2025 12:53
@osulzhenko osulzhenko requested a review from CTMBNara July 9, 2025 07:22
@CTMBNara CTMBNara merged commit 51658c4 into master Jul 9, 2025
7 of 8 checks passed
@CTMBNara CTMBNara deleted the vertx-client-load-balancing branch July 9, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants