Skip to content

Kobler Adapter: Remove sensitive device and user data #4043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CTMBNara merged 1 commit into from
Jul 8, 2025
Merged

Kobler Adapter: Remove sensitive device and user data #4043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.node.ObjectNode;
import com.iab.openrtb.request.BidRequest;
import com.iab.openrtb.request.Device;
import com.iab.openrtb.request.Imp;
import com.iab.openrtb.response.Bid;
import com.iab.openrtb.response.BidResponse;
Expand Down Expand Up @@ -77,9 +78,12 @@ public Result<List<HttpRequest<BidRequest>>> makeHttpRequests(BidRequest bidRequ
}
}

final Device device = bidRequest.getDevice();
final BidRequest modifiedRequest = bidRequest.toBuilder()
.imp(modifiedImps)
.cur(normalizeCurrencies(bidRequest))
.device(device != null ? device.toBuilder().ipv6(null).ip(null).build() : null)
.user(null)
.build();

final String endpoint = isTest(imps.getFirst(), errors) ? devEndpoint : endpointUrl;
Expand Down
21 changes: 21 additions & 0 deletions src/test/java/org/prebid/server/bidder/kobler/KoblerBidderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@

import com.fasterxml.jackson.core.JsonProcessingException;
import com.iab.openrtb.request.BidRequest;
import com.iab.openrtb.request.Device;
import com.iab.openrtb.request.Imp;
import com.iab.openrtb.request.User;
import com.iab.openrtb.response.Bid;
import com.iab.openrtb.response.BidResponse;
import com.iab.openrtb.response.SeatBid;
Expand Down Expand Up @@ -165,6 +167,25 @@ public void makeHttpRequestsShouldAddUsdToCurrenciesIfMissing() {
.containsExactly(List.of("EUR", "USD"));
}

@Test
public void makeHttpRequestsShouldSanitizeDeviceAndUserData() {
// given
final BidRequest bidRequest = givenBidRequest(
request -> request
.device(Device.builder().ip("ip").ipv6("ipv6").ua("ua").build())
.user(User.builder().consent("consent").build()),
givenImp(identity()));

// when
final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest);

// then
assertThat(result.getValue())
.extracting(HttpRequest::getPayload)
.extracting(BidRequest::getDevice, BidRequest::getUser)
.containsExactly(tuple(Device.builder().ua("ua").build(), null));
}

@Test
public void makeBidsShouldReturnErrorIfResponseBodyIsInvalid() {
// given
Expand Down
3 changes: 1 addition & 2 deletions src/test/resources/org/prebid/server/it/openrtb2/kobler/test-kobler-bid-request.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@
}
},
"device": {
"ua": "userAgent",
"ip": "193.168.244.1"
"ua": "userAgent"
},
"at": 1,
"tmax": "${json-unit.any-number}",
Expand Down
Loading