Skip to content

StroeerCore: add adomain to bids #4008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
philipwatson wants to merge 1 commit into from
Closed

StroeerCore: add adomain to bids #4008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/java/org/prebid/server/bidder/stroeercore/StroeerCoreBidder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,7 @@ private BidderBid toBidderBid(BidRequest bidRequest, StroeerCoreBid stroeercoreB
.price(stroeercoreBid.getCpm())
.adm(stroeercoreBid.getAdMarkup())
.crid(stroeercoreBid.getCreativeId())
.adomain(stroeercoreBid.getAdomain())
.ext(bidExt)
.build(),
getBidType(stroeercoreBid.getImpId(), bidRequest.getImp()),
Expand Down
3 changes: 3 additions & 0 deletions src/main/java/org/prebid/server/bidder/stroeercore/model/StroeerCoreBid.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import lombok.Value;

import java.math.BigDecimal;
import java.util.List;

@Value
@Builder
Expand All @@ -29,4 +30,6 @@ public class StroeerCoreBid {
String creativeId;

ObjectNode dsa;

List<String> adomain;
}
4 changes: 4 additions & 0 deletions src/test/java/org/prebid/server/bidder/stroeercore/StroeerCoreBidderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,7 @@ public void makeBidsShouldReturnExpectedBidderBids() throws JsonProcessingExcept
.width(300)
.height(600)
.dsa(dsaResponse.deepCopy())
.adomain(null)
.build();

final StroeerCoreBid videoBid = StroeerCoreBid.builder()
Expand All @@ -304,6 +305,7 @@ public void makeBidsShouldReturnExpectedBidderBids() throws JsonProcessingExcept
.cpm(BigDecimal.valueOf(1.58))
.creativeId("vid")
.dsa(null)
.adomain(List.of("random-domain-dot-com", "test.com"))
.build();

final StroeerCoreBidResponse response = StroeerCoreBidResponse.of(List.of(bannerBid, videoBid));
Expand All @@ -321,6 +323,7 @@ public void makeBidsShouldReturnExpectedBidderBids() throws JsonProcessingExcept
.crid("foo")
.w(300)
.h(600)
.adomain(null)
.ext(mapper.createObjectNode().set("dsa", dsaResponse))
.build();

Expand All @@ -330,6 +333,7 @@ public void makeBidsShouldReturnExpectedBidderBids() throws JsonProcessingExcept
.adm("<vast><span></span></vast>")
.price(BigDecimal.valueOf(1.58))
.crid("vid")
.adomain(List.of("random-domain-dot-com", "test.com"))
.ext(null)
.build();

Expand Down
Loading