Skip to content

Conversation

@Net-burst
Copy link
Collaborator

@Net-burst Net-burst commented Apr 11, 2025

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

We do best effort to keep our core dependencies up to date to have the latest optimizations, bug and security fixes.

🧠 Rationale behind the change

General maintenance.

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@Net-burst Net-burst requested review from And1sS and CTMBNara April 11, 2025 03:07
@Net-burst Net-burst force-pushed the housekeeping/core-components-version-bump branch from 4a0abcb to 2eecf4e Compare April 17, 2025 00:00
@Net-burst Net-burst marked this pull request as ready for review April 17, 2025 00:08
@Net-burst Net-burst force-pushed the housekeeping/core-components-version-bump branch from 72fa511 to 365afd8 Compare April 25, 2025 15:15
@CTMBNara CTMBNara merged commit 46220c7 into master Apr 29, 2025
8 checks passed
@CTMBNara CTMBNara deleted the housekeeping/core-components-version-bump branch April 29, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants