Test: Bid rounding #3903
Merged
Test: Bid rounding #3903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g' into qaa/bid-rounding
osulzhenko
requested changes
May 22, 2025
|
|
||
| class BidRoundingSpec extends BaseSpec { | ||
|
|
||
| def "PBS should round bid value to the down when account bid rounding empty or unknown"() { |
Collaborator
There was a problem hiding this comment.
PBS should round bid value down when account bid rounding setting is #bidRoundingValue. Same for others
| accountDao.save(account) | ||
|
|
||
| and: "Default bid response" | ||
| def bidPrice = PBSUtils.getRandomFloorValue(0.15, 0.19) |
Comment on lines
111
to
139
| def "PBS should round bid value to the 50% down and 50% up when account bid rounding time split"() { | ||
| given: "Default bid request" | ||
| def bidRequest = BidRequest.getDefaultBidRequest().tap { | ||
| ext.prebid.targeting = new Targeting() | ||
| } | ||
|
|
||
| and: "Account in the DB" | ||
| def account = getAccountWithBidRounding(bidRequest.accountId, accountAuctionConfig) | ||
| accountDao.save(account) | ||
|
|
||
| and: "Default bid response" | ||
| def bidPrice = PBSUtils.randomFloorValue | ||
| def bidResponse = BidResponse.getDefaultBidResponse(bidRequest).tap { | ||
| seatbid[0].bid[0].price = bidPrice | ||
| } | ||
| bidder.setResponse(bidRequest.id, bidResponse) | ||
|
|
||
| when: "PBS processes auction request" | ||
| def response = defaultPbsService.sendAuctionRequest(bidRequest) | ||
|
|
||
| then: "Targeting hb_pb should be round" | ||
| def targeting = response.seatbid[0].bid[0].ext.prebid.targeting | ||
| assert targeting["hb_pb"] == getRoundedTargetingValueWithDefaultPrecision(bidPrice) || | ||
| getRoundedTargetingValueWithUpPrecision(bidPrice) | ||
|
|
||
| where: | ||
| accountAuctionConfig << [new AccountAuctionConfig(bidRounding: TIME_SPLIT), | ||
| new AccountAuctionConfig(bidRoundingSnakeCase: TIME_SPLIT)] | ||
| } |
Collaborator
There was a problem hiding this comment.
We should never use the or operator in the assert statement. Besides, I’m not sure this test is valid or helpful in any way because it will always pass
osulzhenko
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check