Epsilon: native support #3880
Epsilon: native support #3880
Conversation
johnwier
force-pushed
the
cnvr_nativesupport
branch
3 times, most recently
from
d9ef2af to
ad3b6f1
Compare
johnwier
force-pushed
the
cnvr_nativesupport
branch
from
ad3b6f1 to
b6efb77
Compare
johnwier
force-pushed
the
cnvr_nativesupport
branch
from
c6625b3 to
31ada3b
Compare
|
Is it a port from PBS-Go? If yes, please link the PR. |
|
This is a port from PBS prebid/prebid-server#4277 |
AntoxaAntoxic
left a comment
AntoxaAntoxic
left a comment
There was a problem hiding this comment.
Not sure if it's a significant issue, but in PBS-Java, epsilon is the base bidder with conversant as its alias, whereas in PBS-Go, it's the other way around.
| } | ||
|
|
||
| @Test | ||
| public void makeBidsShouldReturnResultForNativeBidsWithExpectedFields() throws JsonProcessingException { |
There was a problem hiding this comment.
the test order is messed up a little bit, please fix
There was a problem hiding this comment.
Can you give me a bit more detail. I don't work with java much, where did I go wrong
There was a problem hiding this comment.
for the purpose of code clarity it's better not to mix up the tests that test different methods
place first tests starting from makeHttpRequestsShould and then starting from makeBidsShould
There was a problem hiding this comment.
Just to clarify: Anton asks to move the old tests so that they are in the "correct" order. This doesn't apply to the new method you added.
| @Test | ||
| public void makeBidsShouldReturnResultForNativeBidsWithExpectedFields() throws JsonProcessingException { | ||
| // given | ||
|
|
There was a problem hiding this comment.
remove the empty line
This is related to #2654 It started as conversant and was changed to epsilon. As long as both names work I'm ok with it. |
|
@johnwier do you have any problems with tackling the comments? feel free to ask us anything that could be helpful for you |
|
@johnwier any updates on this one? |
johnwier
force-pushed
the
cnvr_nativesupport
branch
from
2dd6bb8 to
3cc27ae
Compare
4 participants
🔧 Type of changes
✨ What's the context?
Update the Epsilon bid adapter to allow Native requests
This is a port from PBS prebid/prebid-server#4277
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check