Tests: Enforce Random Bid Id Feature #3879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marki1an
requested changes
Mar 31, 2025
Collaborator
marki1an
left a comment
marki1an
left a comment
There was a problem hiding this comment.
Please update tests with the Events object to check if the bid is properly populated
event?t=win&b=${bid.id}
| def pbsConfig = ['auction.enforce-random-bid-id': 'true'] | ||
| def pbsService = pbsServiceFactory.getService(pbsConfig) | ||
|
|
||
| and: "Default big request" |
Collaborator
There was a problem hiding this comment.
Typo: "Default bid request"
| and: "BidResponse should contain bid.id equals to generated pr-bid-id" | ||
| assert response.seatbid.bid.id.flatten().sort() != [originalBidId] | ||
|
|
||
| and: "Bidder request should contain generated pb-bid-id" |
Collaborator
There was a problem hiding this comment.
Suggested change
| and: "Bidder request should contain generated pb-bid-id" | |
| and: "Bid request should contain generated pb-bid-id" |
| } | ||
|
|
||
| def "PBS should override short bid.id with random uuid when enforce-random-bid-id is enabled"() { | ||
| given: "PBS with disabled generate-bid-id" |
Collaborator
There was a problem hiding this comment.
Suggested change
| given: "PBS with disabled generate-bid-id" | |
| given: "PBS with enabled generate-bid-id" |
| def pbsConfig = ["auction.enforce-random-bid-id": enforceRandomBidId] | ||
| def pbsService = pbsServiceFactory.getService(pbsConfig) | ||
|
|
||
| and: "Default big request" |
| } | ||
|
|
||
| def "PBS shouldn't override long enough bid.id with random uuid when enforce-random-bid-id is enabled"() { | ||
| given: "PBS with disabled generate-bid-id" |
Collaborator
There was a problem hiding this comment.
Suggested change
| given: "PBS with disabled generate-bid-id" | |
| given: "PBS with enabled generate-bid-id" |
marki1an
requested changes
Mar 31, 2025
Comment on lines
678
to
679
| // cleanup: "Stop and remove pbs container" | ||
| // pbsServiceFactory.removeContainer(pbsConfig) |
marki1an
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check