Tests: adjust floors for bidadjustments #3868
Merged
+1,522
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osulzhenko
added
do not merge
…ional-tests/adjust-floors
osulzhenko
changed the base branch from
master
to
bid-adjustments-for-price-floors
…ional-tests/adjust-floors
marki1an
requested changes
May 27, 2025
| def response = pbsService.sendAuctionRequest(bidRequest) | ||
|
|
||
| then: "Final bid price should be adjusted for big with dealId" | ||
| response.seatbid.first.bid.find { it.dealid == dealId } |
Collaborator
Author
There was a problem hiding this comment.
It's dead code that does nothing
| seatbid.first.bid.first.price = originalPrice | ||
| seatbid.first.bid.first.dealid = dealId | ||
| } | ||
| } as BidResponse |
Collaborator
There was a problem hiding this comment.
Do we need as BidResponse?
| and: "Bidder request should contain currency from request" | ||
| and: "Bidder request should contain original imp.floors" | ||
| def bidderRequest = bidder.getBidderRequest(bidRequest.id) | ||
| assert bidderRequest.cur == [currency] |
Collaborator
There was a problem hiding this comment.
Why currency assert removed?
| private static final Integer MAX_STATIC_ADJUST_VALUE = Integer.MAX_VALUE | ||
| private static final String WILDCARD = '*' | ||
|
|
||
| private static final Map config = CURRENCY_CONVERTER_CONFIG + |
Collaborator
There was a problem hiding this comment.
Please rename the config to PBS_CONFIG
| STATIC | PBSUtils.getRandomPrice(MAX_CPM_ADJUST_VALUE, MAX_STATIC_ADJUST_VALUE) | ANY | getBidRequestWithFloors(MediaType.BANNER) | ||
| } | ||
|
|
||
| def "PBS should left original bidderRequest with null floors when request has bidAdjustments config"() { |
Collaborator
There was a problem hiding this comment.
Looks like It's a similar test to PBS should adjust bid price for matching bidder and left original bidderRequest with null floors when request has bidAdjustments config
Collaborator
Author
There was a problem hiding this comment.
In most cases, they are similar, but for floors, you have floors config enabled and floors specified inside request
Comment on lines
1164
to
1188
| private static BidRequest getDefaultVideoRequestWithPlacement(VideoPlacementSubtypes videoPlacementSubtypes) { | ||
| getBidRequestWithFloors(MediaType.VIDEO).tap { | ||
| imp.first.video.tap { | ||
| placement = videoPlacementSubtypes | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private static BidRequest getDefaultVideoRequestWithPlcmt(VideoPlcmtSubtype videoPlcmtSubtype) { | ||
| getBidRequestWithFloors(MediaType.VIDEO).tap { | ||
| imp.first.video.tap { | ||
| plcmt = videoPlcmtSubtype | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private static BidRequest getDefaultVideoRequestWithPlcmtAndPlacement(VideoPlcmtSubtype videoPlcmtSubtype, | ||
| VideoPlacementSubtypes videoPlacementSubtypes) { | ||
| getBidRequestWithFloors(MediaType.VIDEO).tap { | ||
| imp.first.video.tap { | ||
| plcmt = videoPlcmtSubtype | ||
| placement = videoPlacementSubtypes | ||
| } | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
private static BidRequest getDefaultVideoRequestWithPlacement(VideoPlacementSubtypes videoPlacementSubtypes) {
getDefaultVideoRequestWithPlcmtAndPlacement(null, videoPlacementSubtypes)
}
private static BidRequest getDefaultVideoRequestWithPlcmt(VideoPlcmtSubtype videoPlcmtSubtype) {
getDefaultVideoRequestWithPlcmtAndPlacement(videoPlcmtSubtype, null)
}
private static BidRequest getDefaultVideoRequestWithPlcmtAndPlacement(VideoPlcmtSubtype videoPlcmtSubtype,
VideoPlacementSubtypes videoPlacementSubtypes) {
getBidRequestWithFloors(MediaType.VIDEO).tap {
imp.first.video.tap {
plcmt = videoPlcmtSubtype
placement = videoPlacementSubtypes
}
}
}
marki1an
requested changes
May 27, 2025
Comment on lines
725
to
731
| and: "Default bid response with JPY currency" | ||
| def originalPrice = PBSUtils.randomDecimal | ||
| def bidResponse = BidResponse.getDefaultBidResponse(bidRequest).tap { | ||
| cur = USD | ||
| seatbid.first.bid.first.price = originalPrice | ||
| } | ||
| bidder.setResponse(bidRequest.id, bidResponse) |
marki1an
requested changes
May 29, 2025
| and: "Bidder request should contain default currency" | ||
| and: "Bidder request should contain original imp.floors" | ||
| def bidderRequest = bidder.getBidderRequest(bidRequest.id) | ||
| assert bidderRequest.cur == [currency] |
Collaborator
There was a problem hiding this comment.
Same here, please leave a bidder request.cur
Collaborator
There was a problem hiding this comment.
Please check another cases
| cur = currency | ||
| seatbid.first.bid.first.price = originalPrice | ||
| seatbid.first.bid.first.dealid = PBSUtils.randomString | ||
| } as BidResponse |
Collaborator
There was a problem hiding this comment.
I think it isn't needed, same for others
|
|
||
| and: "Bidder request should contain reversed imp.floors" | ||
| def bidderRequest = bidder.getBidderRequest(bidRequest.id) | ||
| assert bidderRequest.imp.bidFloorCur == [currency, currency] |
Collaborator
There was a problem hiding this comment.
Please also add bidderRequest.cur, and same for other.
| price = originalPrice | ||
| ext = new BidExt() | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Please remove empty line
| def currency = EUR | ||
| def impPrice = PBSUtils.getRandomPrice(MAX_CPM_ADJUST_VALUE) | ||
| def bidRequest = getBidRequestWithFloors(MediaType.BANNER).tap { | ||
| cur = [EUR] |
|
|
||
| then: "Final bid price should be adjusted" | ||
| def bidAdjustedPrice = originalPrice * bidAdjustmentFactorsPrice | ||
| assert !response.ext.warnings |
Collaborator
There was a problem hiding this comment.
Please add new and: block for warning and errors
marki1an
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check