Skip to content

Test:Multiple bidder codes #3850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
osulzhenko merged 1 commit into from
Mar 20, 2025
+208 −5
Merged

Test:Multiple bidder codes #3850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
180 changes: 175 additions & 5 deletions src/test/groovy/org/prebid/server/functional/tests/AlternateBidderCodeSpec.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import org.prebid.server.functional.model.request.auction.Targeting
import org.prebid.server.functional.model.response.auction.BidExt
import org.prebid.server.functional.model.response.auction.BidResponse
import org.prebid.server.functional.model.response.auction.ErrorType
import org.prebid.server.functional.service.PrebidServerException
import org.prebid.server.functional.service.PrebidServerService
import org.prebid.server.functional.util.PBSUtils
import spock.lang.Shared
Expand Down Expand Up @@ -78,6 +79,9 @@ class AlternateBidderCodeSpec extends BaseSpec {
assert targeting["hb_bidder"] == ALIAS.value
assert targeting["hb_bidder_${ALIAS}"] == ALIAS.value

and: "Response should contain repose millis with corresponding bidder"
assert response.ext.responsetimemillis.containsKey(ALIAS.value)

and: "Bidder request should be valid"
assert bidder.getBidderRequests(bidRequest.id)

Expand Down Expand Up @@ -127,6 +131,9 @@ class AlternateBidderCodeSpec extends BaseSpec {
assert targeting["hb_bidder"] == AMX.value
assert targeting["hb_bidder_${AMX}"] == AMX.value

and: "Response should contain repose millis with corresponding bidder"
assert response.ext.responsetimemillis.containsKey(AMX.value)

and: "Bidder request should be valid"
assert bidder.getBidderRequests(bidRequest.id)

Expand Down Expand Up @@ -172,6 +179,9 @@ class AlternateBidderCodeSpec extends BaseSpec {
assert targeting["hb_bidder"] == AMX.value
assert targeting["hb_bidder_${AMX}"] == AMX.value

and: "Response should contain repose millis with corresponding bidder"
assert response.ext.responsetimemillis.containsKey(AMX.value)

and: "Bidder request should be valid"
assert bidder.getBidderRequests(bidRequest.id)

Expand Down Expand Up @@ -214,6 +224,9 @@ class AlternateBidderCodeSpec extends BaseSpec {
assert targeting["hb_bidder"] == bidderCode.value
assert targeting["hb_bidder_${bidderCode}"] == bidderCode.value

and: "Response should contain repose millis with corresponding bidder"
assert response.ext.responsetimemillis.containsKey(bidderCode.value)

and: "Bidder request should be valid"
assert bidder.getBidderRequests(bidRequest.id)

Expand Down Expand Up @@ -270,6 +283,9 @@ class AlternateBidderCodeSpec extends BaseSpec {
def logs = pbsServiceWithAmxBidder.getLogsByValue(bidRequest.accountId)
assert logs.contains(INVALID_BIDDER_CODE_LOGS.formatted(bidderName, AMX, bidRequest.accountId))

and: "Response should contain repose millis with corresponding bidder"
assert response.ext.responsetimemillis.containsKey(AMX.value)

and: "Bidder request should be valid"
assert bidder.getBidderRequests(bidRequest.id)

Expand Down Expand Up @@ -325,6 +341,9 @@ class AlternateBidderCodeSpec extends BaseSpec {
and: "Bidder request should be valid"
assert bidder.getBidderRequests(bidRequest.id)

and: "Response should contain repose millis with corresponding bidder"
assert response.ext.responsetimemillis.containsKey(ALIAS.value)

and: "PBS should emit validation metrics"
def metrics = pbsServiceWithAmxBidder.sendCollectedMetricsRequest()
assert metrics[ADAPTER_RESPONSE_VALIDATION_METRICS.formatted(ALIAS)]
Expand Down Expand Up @@ -376,6 +395,9 @@ class AlternateBidderCodeSpec extends BaseSpec {
assert targeting["hb_bidder"] == GENERIC.value
assert targeting["hb_bidder_${GENERIC}"] == GENERIC.value

and: "Response should contain repose millis with corresponding bidder"
assert response.ext.responsetimemillis.containsKey(GENERIC.value)

and: "Bidder request should be valid"
assert bidder.getBidderRequests(bidRequest.id)

Expand Down Expand Up @@ -430,6 +452,9 @@ class AlternateBidderCodeSpec extends BaseSpec {
assert targeting["hb_bidder"] == bidderCode.value
assert targeting["hb_bidder_${bidderCode}"] == bidderCode.value

and: "Response should contain repose millis with corresponding bidder"
assert response.ext.responsetimemillis.containsKey(bidderCode.value)

and: "Bidder request should be valid"
assert bidder.getBidderRequests(bidRequest.id)

Expand Down Expand Up @@ -481,6 +506,9 @@ class AlternateBidderCodeSpec extends BaseSpec {
assert targeting["hb_bidder"] == AMX.value
assert targeting["hb_bidder_${AMX}"] == AMX.value

and: "Response should contain repose millis with corresponding bidder"
assert response.ext.responsetimemillis.containsKey(AMX.value)

and: "Bidder request should be valid"
assert bidder.getBidderRequests(bidRequest.id)

Expand Down Expand Up @@ -554,6 +582,9 @@ class AlternateBidderCodeSpec extends BaseSpec {
assert !response.ext?.errors
assert !response.ext?.seatnonbid

and: "Response should contain repose millis with corresponding bidder"
assert response.ext.responsetimemillis.containsKey(AMX.value)

and: "Response shouldn't contain demand source"
assert !response.seatbid.first.bid.first.ext.prebid.meta.demandSource

Expand All @@ -567,16 +598,44 @@ class AlternateBidderCodeSpec extends BaseSpec {
new AlternateBidderCodes(enabled: true),
new AlternateBidderCodes(enabled: false),
new AlternateBidderCodes(bidders: [(AMX): new BidderConfig()]),
new AlternateBidderCodes(bidders: [(UNKNOWN): new BidderConfig()]),
new AlternateBidderCodes(enabled: true, bidders: [(AMX): new BidderConfig()]),
new AlternateBidderCodes(enabled: true, bidders: [(UNKNOWN): new BidderConfig()]),
new AlternateBidderCodes(enabled: false, bidders: [(UNKNOWN): new BidderConfig()]),
new AlternateBidderCodes(enabled: false, bidders: [(AMX): new BidderConfig()]),
new AlternateBidderCodes(bidders: [(AMX): new BidderConfig(enabled: false, allowedBidderCodes: [UNKNOWN])]),
new AlternateBidderCodes(bidders: [(UNKNOWN): new BidderConfig(enabled: false, allowedBidderCodes: [AMX])]),
new AlternateBidderCodes(enabled: false, bidders: [(AMX): new BidderConfig(enabled: false, allowedBidderCodes: [UNKNOWN])]),
new AlternateBidderCodes(enabled: true, bidders: [(AMX): new BidderConfig(enabled: false, allowedBidderCodes: [UNKNOWN])]),]
}

def "PBS should validate and throw error when request alternate bidder codes not fully configured"() {
given: "Default bid request with alternate bidder codes"
def bidRequest = getBidRequestWithAmxBidderAndAlternateBidderCode().tap {
ext.prebid.alternateBidderCodes = requestedAlternateBidderCodes
}

and: "Bid response with bidder code"
def bidResponse = BidResponse.getDefaultBidResponse(bidRequest, AMX).tap {
it.seatbid[0].bid[0].ext = new BidExt(bidderCode: AMX)
}
bidder.setResponse(bidRequest.id, bidResponse)

and: "Flash metrics"
flushMetrics(pbsServiceWithAmxBidder)

when: "PBS processes auction request"
pbsServiceWithAmxBidder.sendAuctionRequest(bidRequest)

then: "Request should fail with error"
def exception = thrown(PrebidServerException)
assert exception.statusCode == 400
assert exception.responseBody == "Invalid request format: " +
"request.ext.prebid.alternatebiddercodes.bidders.unknown is not a known bidder or alias"


where:
requestedAlternateBidderCodes << [new AlternateBidderCodes(bidders: [(UNKNOWN): new BidderConfig()]),
new AlternateBidderCodes(enabled: true, bidders: [(UNKNOWN): new BidderConfig()]),
new AlternateBidderCodes(enabled: false, bidders: [(UNKNOWN): new BidderConfig()]),
new AlternateBidderCodes(bidders: [(UNKNOWN): new BidderConfig(enabled: false, allowedBidderCodes: [AMX])]),
new AlternateBidderCodes(enabled: false, bidders: [(UNKNOWN): new BidderConfig(enabled: false, allowedBidderCodes: [AMX])]),
new AlternateBidderCodes(enabled: true, bidders: [(AMX): new BidderConfig(enabled: false, allowedBidderCodes: [UNKNOWN])]),
new AlternateBidderCodes(enabled: true, bidders: [(UNKNOWN): new BidderConfig(enabled: false, allowedBidderCodes: [AMX])])]
}

Expand Down Expand Up @@ -615,6 +674,9 @@ class AlternateBidderCodeSpec extends BaseSpec {
assert targeting["hb_bidder"] == GENERIC.value
assert targeting["hb_bidder_${GENERIC}"] == GENERIC.value

and: "Response should contain repose millis with corresponding bidder"
assert response.ext.responsetimemillis.containsKey(GENERIC.value)

and: "Bidder request should be valid"
assert bidder.getBidderRequests(bidRequest.id)

Expand Down Expand Up @@ -666,6 +728,9 @@ class AlternateBidderCodeSpec extends BaseSpec {
assert targeting["hb_bidder"] == GENERIC.value
assert targeting["hb_bidder_${GENERIC}"] == GENERIC.value

and: "Response should contain repose millis with corresponding bidder"
assert response.ext.responsetimemillis.containsKey(GENERIC.value)

and: "Bidder request should be valid"
assert bidder.getBidderRequests(bidRequest.id)

Expand Down Expand Up @@ -735,6 +800,9 @@ class AlternateBidderCodeSpec extends BaseSpec {
def metrics = pbsServiceWithAmxBidder.sendCollectedMetricsRequest()
assert metrics[ADAPTER_RESPONSE_VALIDATION_METRICS.formatted(AMX)]

and: "Response should contain repose millis with corresponding bidder"
assert response.ext.responsetimemillis.containsKey(AMX.value)

and: "Bidder request should be valid"
assert bidder.getBidderRequests(bidRequest.id)
}
Expand Down Expand Up @@ -788,6 +856,9 @@ class AlternateBidderCodeSpec extends BaseSpec {
def metrics = pbsServiceWithAmxBidder.sendCollectedMetricsRequest()
assert metrics[ADAPTER_RESPONSE_VALIDATION_METRICS.formatted(AMX)]

and: "Response should contain repose millis with corresponding bidder"
assert response.ext.responsetimemillis.containsKey(AMX.value)

and: "Bidder request should be valid"
assert bidder.getBidderRequests(bidRequest.id)

Expand Down Expand Up @@ -837,6 +908,9 @@ class AlternateBidderCodeSpec extends BaseSpec {
and: "Bidder request should be valid"
assert bidder.getBidderRequests(bidRequest.id)

and: "Response should contain repose millis with corresponding bidder"
assert response.ext.responsetimemillis.containsKey(GENERIC.value)

and: "Response shouldn't contain demand source"
assert !response.seatbid.first.bid.first.ext.prebid.meta.demandSource

Expand Down Expand Up @@ -884,6 +958,9 @@ class AlternateBidderCodeSpec extends BaseSpec {
assert targeting["hb_bidder"] == GENERIC.value
assert targeting["hb_bidder_${GENERIC}"] == GENERIC.value

and: "Response should contain repose millis with corresponding bidder"
assert response.ext.responsetimemillis.containsKey(GENERIC.value)

and: "Bidder request should be valid"
assert bidder.getBidderRequests(bidRequest.id)

Expand Down Expand Up @@ -937,6 +1014,9 @@ class AlternateBidderCodeSpec extends BaseSpec {
assert targeting["hb_bidder"] == GENERIC.value
assert targeting["hb_bidder_${GENERIC}"] == GENERIC.value

and: "Response should contain repose millis with corresponding bidder"
assert response.ext.responsetimemillis.containsKey(GENERIC.value)

and: "Bidder request should be valid"
assert bidder.getBidderRequests(bidRequest.id)

Expand Down Expand Up @@ -997,6 +1077,9 @@ class AlternateBidderCodeSpec extends BaseSpec {
assert targeting["hb_bidder"] == GENERIC.value
assert targeting["hb_bidder_${GENERIC}"] == GENERIC.value

and: "Response should contain repose millis with corresponding bidder"
assert response.ext.responsetimemillis.containsKey(GENERIC.value)

and: "Response shouldn't contain warnings and errors and seatNonBid"
assert !response.ext?.warnings
assert !response.ext?.errors
Expand Down Expand Up @@ -1057,6 +1140,9 @@ class AlternateBidderCodeSpec extends BaseSpec {
assert targeting["hb_bidder"] == AMX.value
assert targeting["hb_bidder_${AMX}"] == AMX.value

and: "Response should contain repose millis with corresponding bidder"
assert response.ext.responsetimemillis.containsKey(AMX.value)

and: "Bidder request should be valid"
assert bidder.getBidderRequests(bidRequest.id)

Expand Down Expand Up @@ -1114,6 +1200,9 @@ class AlternateBidderCodeSpec extends BaseSpec {
def metrics = pbsServiceWithAmxBidder.sendCollectedMetricsRequest()
assert metrics[ADAPTER_RESPONSE_VALIDATION_METRICS.formatted(AMX)]

and: "Response should contain repose millis with corresponding bidder"
assert response.ext.responsetimemillis.containsKey(AMX.value)

and: "Bidder request should be valid"
assert bidder.getBidderRequests(bidRequest.id)

Expand Down Expand Up @@ -1166,6 +1255,9 @@ class AlternateBidderCodeSpec extends BaseSpec {
def metrics = pbsServiceWithAmxBidder.sendCollectedMetricsRequest()
assert metrics[ADAPTER_RESPONSE_VALIDATION_METRICS.formatted(AMX)]

and: "Response should contain repose millis with corresponding bidder"
assert response.ext.responsetimemillis.containsKey(AMX.value)

and: "Bidder request should be valid"
assert bidder.getBidderRequests(bidRequest.id)

Expand Down Expand Up @@ -1227,6 +1319,9 @@ class AlternateBidderCodeSpec extends BaseSpec {
def metrics = pbsService.sendCollectedMetricsRequest()
assert metrics[ADAPTER_RESPONSE_VALIDATION_METRICS.formatted(AMX)]

and: "Response should contain repose millis with corresponding bidder"
assert response.ext.responsetimemillis.containsKey(AMX.value)

and: "Bidder request should be valid"
assert bidder.getBidderRequests(bidRequest.id)

Expand Down Expand Up @@ -1274,6 +1369,9 @@ class AlternateBidderCodeSpec extends BaseSpec {
assert targeting["hb_bidder"] == GENERIC.value
assert targeting["hb_bidder_${GENERIC}"] == GENERIC.value

and: "Response should contain repose millis with corresponding bidder"
assert response.ext.responsetimemillis.containsKey(GENERIC.value)

and: "Bidder request should be valid"
assert bidder.getBidderRequests(bidRequest.id)

Expand Down Expand Up @@ -1331,6 +1429,9 @@ class AlternateBidderCodeSpec extends BaseSpec {
assert targeting["hb_bidder"] == GENERIC.value
assert targeting["hb_bidder_${GENERIC}"] == GENERIC.value

and: "Response should contain repose millis with corresponding bidder"
assert response.ext.responsetimemillis.containsKey(GENERIC.value)

and: "Bidder request should be valid"
assert bidder.getBidderRequests(bidRequest.id)

Expand All @@ -1351,6 +1452,72 @@ class AlternateBidderCodeSpec extends BaseSpec {
null | new AlternateBidderCodes(enabled: true, bidders: [(ALIAS): new BidderConfig(enabled: true, allowedBidderCodes: [GENERIC])])
}

def "PBS shouldn't discard bid when alternate bidder code allow and soft alias with case with base bidder in alternate bidder code"() {
given: "Default bid request with amx bidder"
def bidRequest = getBidRequestWithAmxBidderAndAlternateBidderCode().tap {
imp[0].ext.prebid.bidder.aliasUpperCase = new Generic()
imp[0].ext.prebid.bidder.amx = null
ext.prebid.aliases = [(ALIAS.value): AMX]
ext.prebid.alternateBidderCodes = requestAlternateBidderCode
}

and: "Save account config into DB with alternate bidder codes"
def account = getAccountWithAlternateBidderCode(bidRequest).tap {
config.alternateBidderCodes = accountAlternateBidderCodes
}
accountDao.save(account)

and: "Bid response with bidder code"
def bidResponse = BidResponse.getDefaultBidResponse(bidRequest, ALIAS).tap {
it.seatbid[0].bid[0].ext = new BidExt(bidderCode: GENERIC)
}
bidder.setResponse(bidRequest.id, bidResponse)

and: "Flash metrics"
flushMetrics(pbsServiceWithAmxBidder)

when: "PBS processes auction request"
def response = pbsServiceWithAmxBidder.sendAuctionRequest(bidRequest)

then: "Bid response should contain exp data"
assert response.seatbid.seat == [GENERIC]

and: "Response should contain adapter code"
assert response.seatbid.bid.ext.prebid.meta.adapterCode.flatten() == [AMX]

and: "Response shouldn't contain demand source"
assert !response.seatbid.first.bid.first.ext.prebid.meta.demandSource

and: "Response should contain bidder targeting"
def targeting = response.seatbid[0].bid[0].ext.prebid.targeting
assert targeting["hb_pb_${GENERIC}"]
assert targeting["hb_size_${GENERIC}"]
assert targeting["hb_bidder"] == GENERIC.value
assert targeting["hb_bidder_${GENERIC}"] == GENERIC.value

and: "Response should contain repose millis with corresponding bidder"
assert response.ext.responsetimemillis.containsKey(GENERIC.value)

and: "Bidder request should be valid"
assert bidder.getBidderRequests(bidRequest.id)

and: "Response shouldn't contain warnings and error and seatNonBid"
assert !response.ext?.warnings
assert !response.ext?.errors
assert !response.ext?.seatnonbid

and: "PBS shouldn't emit validation metrics"
def metrics = pbsServiceWithAmxBidder.sendCollectedMetricsRequest()
assert !metrics[ADAPTER_RESPONSE_VALIDATION_METRICS.formatted(ALIAS)]
assert !metrics[ADAPTER_RESPONSE_VALIDATION_METRICS.formatted(GENERIC)]
assert !metrics[ADAPTER_RESPONSE_VALIDATION_METRICS.formatted(AMX)]

where:
requestAlternateBidderCode | accountAlternateBidderCodes
new AlternateBidderCodes(enabled: true, bidders: [(AMX): new BidderConfig(enabled: true, allowedBidderCodes: [GENERIC])]) | null
null | new AlternateBidderCodes(enabled: true, bidders: [(AMX): new BidderConfig(enabled: true, allowedBidderCodes: [GENERIC])])
}

def "PBS should populate adapter code with requested bidder when conflict soft and hard alias and alternate bidder code"() {
given: "PBS config with bidder"
def pbsConfig = AMX_CONFIG + ["adapters.amx.aliases.alias.enabled" : "true",
Expand Down Expand Up @@ -1391,6 +1558,9 @@ class AlternateBidderCodeSpec extends BaseSpec {
assert targeting["hb_bidder"] == GENERIC.value
assert targeting["hb_bidder_${GENERIC}"] == GENERIC.value

and: "Response should contain repose millis with corresponding bidder"
assert response.ext.responsetimemillis.containsKey(GENERIC.value)

and: "Bidder request should be valid"
assert bidder.getBidderRequests(bidRequest.id)

Expand Down
Loading