Add aws default credentials provider #3842
Merged
+63
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muuki88
previously approved these changes
Mar 21, 2025
Contributor
muuki88
left a comment
muuki88
left a comment
There was a problem hiding this comment.
This is great. Thanks for improving this feature 😊
osulzhenko
previously approved these changes
Mar 25, 2025
CTMBNara
requested changes
Apr 1, 2025
src/main/java/org/prebid/server/spring/config/SettingsConfiguration.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/spring/config/SettingsConfigurationTest.java
Outdated
Show resolved
Hide resolved
There is no need to unit test the configuration.
The "HookStageExecutorTest#shouldExecuteEntrypointHooksToleratingTimeoutAndFailedFuture" test has been failing intermittently due to strict time boundaries (50-70ms) for hook execution. This commit increases the acceptable range to account for slight variations in execution time across different environments. - Previous range: 50-70ms - New range: 50-80ms
Adopting feedback from PR. prebid#3842 (comment)
CTMBNara
approved these changes
Apr 19, 2025
muuki88
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
Currently, the S3 integration for prebid-server-java requires AWS credentials to be explicitly defined in the config yaml file. The SettingsConfiguration class in PBS Java uses AwsBasicCredentials to authenticate S3 requests, making credential storage in the YAML file mandatory. However, this is not good practice for credential management. This PR adds another credentials provider that will look for credentials in this order:
🧠 Rationale behind the change
So that S3 integration can be used with the recommended practices for AWS credential management.
🧪 Test plan
🏎 Quality check