-
Notifications
You must be signed in to change notification settings - Fork 224
New Adapter: 152 Media - Adkernel alias #3829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Adapter: 152 Media - Adkernel alias #3829
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, add tests for both aliases
See ZetaGlobalSspTest as an example
87d94ac
CTMBNara
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add required config properties for new test in test-application.properties
|
required update |
|
@armando-fs Still requires updates and unit test fixes |
|
@armando-fs will mark this as blocked for now |
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
New Adapter: 152 Media - Adkernel alias
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
Mere alias, no changes needed, no trade-offs.
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check