Skip to content

Conversation

@armando-fs
Copy link
Contributor

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes?
New Adapter: 152 Media - Adkernel alias

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?
Mere alias, no changes needed, no trade-offs.

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

katherynhrabik
katherynhrabik previously approved these changes Mar 14, 2025
kim-ng93
kim-ng93 previously approved these changes Mar 14, 2025
Copy link
Collaborator

@CTMBNara CTMBNara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add tests for both aliases

See ZetaGlobalSspTest as an example

@armando-fs armando-fs dismissed stale reviews from kim-ng93 and katherynhrabik via 87d94ac March 27, 2025 23:21
@armando-fs armando-fs requested a review from CTMBNara March 27, 2025 23:22
Copy link
Collaborator

@CTMBNara CTMBNara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add required config properties for new test in test-application.properties

@osulzhenko osulzhenko requested a review from CTMBNara April 11, 2025 05:51
@osulzhenko
Copy link
Collaborator

required update

@osulzhenko
Copy link
Collaborator

osulzhenko commented Apr 25, 2025

@armando-fs Still requires updates and unit test fixes

@osulzhenko
Copy link
Collaborator

@armando-fs will mark this as blocked for now

@CTMBNara CTMBNara merged commit 5aeaea2 into prebid:master Jun 3, 2025
8 checks passed
@osulzhenko osulzhenko linked an issue Jun 13, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port PR from PBS-Go: New Adapter: 152 Media - Adkernel alias

5 participants