Skip to content

Rubicon: Segtax update #3813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CTMBNara merged 1 commit into from
Mar 13, 2025
Merged

Rubicon: Segtax update #3813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/prebid/server/bidder/rubicon/RubiconBidder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ public class RubiconBidder implements Bidder<BidRequest> {
private static final String SEGTAX = "segtax";

private static final Set<Integer> USER_SEGTAXES = Set.of(4);
private static final Set<Integer> SITE_SEGTAXES = Set.of(1, 2, 5, 6);
private static final Set<Integer> SITE_SEGTAXES = Set.of(1, 2, 5, 6, 7);

private static final Set<String> STYPE_TO_REMOVE = new HashSet<>(Arrays.asList(PPUID_STYPE, SHA256EMAIL_STYPE,
DMP_STYPE));
Expand Down
5 changes: 3 additions & 2 deletions src/test/java/org/prebid/server/bidder/rubicon/RubiconBidderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1155,7 +1155,7 @@ public void makeHttpRequestsShouldFillSiteExtRpWithSegtaxValuesWithNoMoreThanHun
givenDataWithSegments(3, "thirdSegmentId_", 3),
givenDataWithSegments(4, "fourthSegmentId_", 2),
givenDataWithSegments(5, "fifthSegmentId_", 1),
givenDataWithSegments(6, "sixthSegmentId_", 100),
givenDataWithSegments(6, "sixthSegmentId_", 7),
givenDataWithSegments(7, "seventhSegmentId_", 100)))
.build())
.build()),
Expand All @@ -1177,7 +1177,8 @@ public void makeHttpRequestsShouldFillSiteExtRpWithSegtaxValuesWithNoMoreThanHun
IntStream.range(1, 6).mapToObj(i -> "firstSegmentId_" + i),
IntStream.range(1, 5).mapToObj(i -> "secondSegmentId_" + i),
IntStream.range(1, 2).mapToObj(i -> "fifthSegmentId_" + i),
IntStream.range(1, 86).mapToObj(i -> "sixthSegmentId_" + i))
IntStream.range(1, 8).mapToObj(i -> "sixthSegmentId_" + i),
IntStream.range(1, 79).mapToObj(i -> "seventhSegmentId_" + i))
.toList();

assertThat(targetNode.get("iab").elements()).toIterable().hasSize(95)
Expand Down
Loading