Skip to content

Conversation

@gmiedlar-ox
Copy link
Contributor

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

OpenX started to return mtype field for bids in bid response, so now bid type can be determined based on this property in OpenX bidder adapter.

🧠 Rationale behind the change

We want to determine bid type based on bid mtype from bid response, to be able to process multi-format requests.

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@gmiedlar-ox
Copy link
Contributor Author

@CTMBNara could you please review this PR?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all code related to the old logic.

Copy link
Contributor Author

@gmiedlar-ox gmiedlar-ox Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CTMBNara We would like to keep the old logic and fallback to it when there is no mtype in the bid response.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gmiedlar-ox You can revert the commit at any time later. We don't keep "dead" code in our repository.

Copy link
Contributor Author

@gmiedlar-ox gmiedlar-ox Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CTMBNara I don't think we have "dead" code here. In case bid.getMtype() is null or there is no case match, the "old" getBidType logic will be executed.

case null, default -> impIdToBidType.getOrDefault(bid.getImpid(), BidType.banner);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gmiedlar-ox Yes, you're right. Sorry for that, missed this part

@gmiedlar-ox gmiedlar-ox requested a review from CTMBNara March 13, 2025 13:22
@CTMBNara CTMBNara merged commit fc58f1e into prebid:master Mar 17, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants