Skip to content

Conversation

@Net-burst
Copy link
Collaborator

@Net-burst Net-burst commented Feb 27, 2025

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

Checkstyle enforcement does some basic code style checks and helps ensure that project code style remains coherent. The issue was that the Checkstyle was only applying to Prebid Server Core and not to modules.

🧠 Rationale behind the change

Code style enforcement should apply to the entire Prebid Server code base instead of only Prebid Server Core.

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@osulzhenko osulzhenko added the dependencies Pull requests that update a dependency file label Mar 13, 2025
@Net-burst Net-burst force-pushed the housekeeping/move-checkstyle-to-root branch from 7a8bcc3 to dff5c0e Compare March 24, 2025 14:01
@CTMBNara CTMBNara marked this pull request as ready for review March 27, 2025 13:16
@Net-burst
Copy link
Collaborator Author

LGTM from my perspective. Thanks, @CTMBNara!

osulzhenko
osulzhenko previously approved these changes Apr 14, 2025
Copy link
Collaborator

@osulzhenko osulzhenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…-root

# Conflicts:
#	src/main/java/org/prebid/server/validation/ResponseBidValidator.java
@CTMBNara CTMBNara merged commit 2ebf421 into master Apr 25, 2025
8 checks passed
@CTMBNara CTMBNara deleted the housekeeping/move-checkstyle-to-root branch April 25, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file do not port

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants