-
Notifications
You must be signed in to change notification settings - Fork 224
Core: Move Checkstyle to the root pom.xml #3797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7a8bcc3 to
dff5c0e
Compare
Collaborator
Author
|
LGTM from my perspective. Thanks, @CTMBNara! |
osulzhenko
previously approved these changes
Apr 14, 2025
Collaborator
osulzhenko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…-root # Conflicts: # src/main/java/org/prebid/server/validation/ResponseBidValidator.java
…heckstyle-to-root
osulzhenko
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
Checkstyle enforcement does some basic code style checks and helps ensure that project code style remains coherent. The issue was that the Checkstyle was only applying to Prebid Server Core and not to modules.
🧠 Rationale behind the change
Code style enforcement should apply to the entire Prebid Server code base instead of only Prebid Server Core.
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check