-
Notifications
You must be signed in to change notification settings - Fork 224
Dependencies: resolve maven conflicts between core and bundle #3793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
5f134d5
Dependencies: resolve maven conflicts between core and bundle
osulzhenko a5beede
update after review
osulzhenko 0780053
Merge branch 'refs/heads/master' into resolve-maven-conflicts
osulzhenko ad5b98e
update dependency
osulzhenko f46cb04
update dependency
osulzhenko 75be25a
update dependency
osulzhenko 7fc5818
update dependency
osulzhenko a2fb871
update dependency
osulzhenko b1aaecc
update dependency
osulzhenko 889cba1
update dependency
osulzhenko 86b2f92
update dependency
osulzhenko f3a843c
update dependency
osulzhenko b791ae5
update dependency
osulzhenko 2aa8c68
update dependency
osulzhenko de18717
update dependency
osulzhenko 6f818bf
update dependency
osulzhenko 403124d
update dependency
osulzhenko ef33e16
update dependency
osulzhenko 0808a7b
update dependency
osulzhenko d046f44
comment video in test proto file
osulzhenko e0369aa
comment video in test proto file
osulzhenko aa812f9
update dependencies
osulzhenko 0ea21ce
Merge branch 'refs/heads/master' into resolve-maven-conflicts
osulzhenko 367618a
update dependencies
osulzhenko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please swap
groupIdandartifactId. There is an unspoken convention that groupId should go before artifactId.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And while we're at it, it might be worth bumping dependencies for this module. Google cloud is being updated quite frequently, and we're already several versions behind.