-
Notifications
You must be signed in to change notification settings - Fork 224
Ogury: port new adapter from Go #3788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
CTMBNara
merged 7 commits into
prebid:master
from
zxPhoenix:port-ogury-adapter-from-golang-to-java
Apr 1, 2025
Merged
Ogury: port new adapter from Go #3788
CTMBNara
merged 7 commits into
prebid:master
from
zxPhoenix:port-ogury-adapter-from-golang-to-java
Apr 1, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CTMBNara
requested changes
Mar 4, 2025
CTMBNara
requested changes
Mar 10, 2025
CTMBNara
requested changes
Mar 12, 2025
CTMBNara
requested changes
Mar 13, 2025
src/test/java/org/prebid/server/bidder/ogury/OguryBidderTest.java
Outdated
Show resolved
Hide resolved
Comment on lines
93
to
108
| @Test | ||
| public void makeHttpRequestsShouldReturnErrorWhenRequestDoesNotHaveOguryKeys() { | ||
| // given | ||
| final ObjectNode bidder = mapper.createObjectNode(); | ||
| bidder.putIfAbsent("bidder", mapper.createObjectNode()); | ||
| final BidRequest bidrequest = givenBidRequest(bidRequest -> | ||
| bidRequest.imp(List.of(Imp.builder().ext(bidder).build()))); | ||
|
|
||
| // when | ||
| final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidrequest); | ||
|
|
||
| // then | ||
| assertThat(result.getErrors()).isNotEmpty() | ||
| .contains(BidderError.badInput( | ||
| "Invalid request. assetKey/adUnitId or request.site.publisher.id required")); | ||
| } |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add more tests that cover scenarios:
- impWithOguryParams + site.publisher.id + impWithoutOguryParams
- invalid impWithOguryParams + site.publisher.id + impWithoutOguryParams
- impWithoutOguryParams
- imp.tagId copied from imp.id
- price tests (for each edge case)
- test that checks imp.ext fields aren't lost, and new fields are added/replaced by impExtBidderHoist fields
CTMBNara
requested changes
Mar 18, 2025
src/test/java/org/prebid/server/bidder/ogury/OguryBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/ogury/OguryBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/ogury/OguryBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/ogury/OguryBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/ogury/OguryBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/ogury/OguryBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/ogury/OguryBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/ogury/OguryBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/ogury/OguryBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/ogury/OguryBidderTest.java
Outdated
Show resolved
Hide resolved
CTMBNara
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
New Ogury adapter (Port PR from PBS-Go)
#3700
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
Unit tests with decent coverage
🏎 Quality check