Connatix: Port adapter from PBS-Go #3781

katherynhrabik · 2025-02-24T20:48:29Z

🔧 Type of changes

✨ What's the context?

What's the context for the changes?
New Connatix Adapter (port from Go)
#3601

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?
N/A

🔎 New Bid Adapter Checklist

verify email contact works (I believe this happened go-side. this is a port)
NO fully dynamic hostnames
geographic host parameters are NOT required
direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
[n/a] if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?
Unit tests with decent coverage

🏎 Quality check

Are your changes following our code style guidelines?
Are there any breaking changes in your code?
Does your test coverage exceed 90%?
Are there any erroneous console logs, debuggers or leftover code in your changes?

src/main/java/org/prebid/server/bidder/connatix/ConnatixBidder.java

AntoxaAntoxic · 2025-02-25T09:29:18Z

src/main/java/org/prebid/server/bidder/connatix/ConnatixBidder.java

+    @Override
+    public Result<List<HttpRequest<BidRequest>>> makeHttpRequests(BidRequest request) {
+        // Device IP required - bounce if not available
+        if (request.getDevice() == null


I'd extract device into a separate variable since it's used later as well

src/main/java/org/prebid/server/bidder/connatix/ConnatixBidder.java

src/main/resources/bidder-config/connatix.yaml

src/test/java/org/prebid/server/it/ConnatixTest.java

katherynhrabik · 2025-02-26T19:44:31Z

updates in response to comments are in progress

src/main/java/org/prebid/server/bidder/connatix/ConnatixBidder.java

src/main/resources/bidder-config/connatix.yaml

AntoxaAntoxic · 2025-02-27T09:45:50Z

src/test/java/org/prebid/server/bidder/connatix/ConnatixBidderTest.java

+        final BidRequest bidRequest = givenBidRequest(
+                request -> request.device(Device.builder().ip("deviceIp").build()),
+                impBuilder -> impBuilder.ext(mapper.valueToTree(ExtPrebid.of(null, mapper.createArrayNode())))
+        );


according to the code style closing parenthesis should be on the previous line

please double-check everywhere in the PR

src/main/resources/bidder-config/connatix.yaml

src/main/java/org/prebid/server/bidder/connatix/ConnatixBidder.java

src/main/java/org/prebid/server/proto/openrtb/ext/request/connatix/ExtImpConnatix.java

src/test/java/org/prebid/server/bidder/connatix/ConnatixBidderTest.java

CTMBNara · 2025-03-04T18:01:53Z

src/test/java/org/prebid/server/bidder/connatix/ConnatixBidderTest.java

+        final BidRequest bidRequest = givenBidRequest(
+                request -> request.device(Device.builder().ip("deviceIp").build()),
+                impBuilder -> impBuilder.ext(mapper.valueToTree(ExtPrebid.of(null, mapper.createArrayNode())))
+        );


CTMBNara · 2025-03-04T18:05:43Z

src/test/java/org/prebid/server/bidder/connatix/ConnatixBidderTest.java

+    @SafeVarargs
+    private static BidRequest givenBidRequest(UnaryOperator<BidRequest.BidRequestBuilder> bidRequestCustomizer,
+                                              UnaryOperator<Imp.ImpBuilder>... impCustomizers) {
+        return bidRequestCustomizer.apply(BidRequest.builder()
+                .imp(Stream.of(impCustomizers)
+                        .map(ConnatixBidderTest::givenImp)
+                        .toList()))
+                .build();
+    }
+
+    private static Imp givenImp(UnaryOperator<Imp.ImpBuilder> impCustomizer) {
+        return impCustomizer.apply(Imp.builder()).build();
+    }
+
+    private static Imp givenImp(ExtImpConnatix extImpConnatix) {
+        return givenImp(imp -> imp.ext(mapper.valueToTree(ExtPrebid.of(null, extImpConnatix))));
+    }
+
+    private static ExtImpConnatix givenExt(UnaryOperator<ExtImpConnatix.ExtImpConnatixBuilder> extCustomizer) {
+        return extCustomizer.apply(ExtImpConnatix.builder().placementId("placementId")).build();
+    }


You can simplify all makeHttpRequests* tests by adding default Device object to givenBidRequest method:

private static BidRequest givenBidRequest(UnaryOperator<BidRequest.BidRequestBuilder> bidRequestCustomizer, Imp... imps) { return bidRequestCustomizer.apply(BidRequest.builder() .imp(List.of(imps)) .device(Device.builder().ip("deviceIp).build()) .build(); }

Also, use givenImp and givenBidRequest(UnaryOperator<BidRequest.BidRequestBuilder>, Imp...) combo, instead of current approach

CTMBNara · 2025-03-04T18:06:06Z

src/test/java/org/prebid/server/bidder/connatix/ConnatixBidderTest.java

+        return bidRequestCustomizer.apply(BidRequest.builder().imp(asList(imps))).build();
+    }
+
+    @SafeVarargs


Remove @SafeVarargs annotation

osulzhenko · 2025-03-12T10:44:11Z

@katherynhrabik Please update to actual master

katherynhrabik and others added 7 commits February 13, 2025 15:49

connatix updates thus far

38abb67

stylecheck and adding logic

ff9a8d9

vague cleanup

c8d9838

add testing

816c3f5

fixing tests

7f6042e

Update ConnatixImpExtBidder.java

4597547

Merge branch 'prebid:master' into port-3601-connatix-adapter

a5e3659

katherynhrabik requested review from AntoxaAntoxic and CTMBNara February 24, 2025 20:48

AntoxaAntoxic requested changes Feb 25, 2025

View reviewed changes

This was linked to issues Feb 25, 2025

Port PR from PBS-Go: Connatix: Add viewability field #3746

Closed

Port PR from PBS-Go: New Adapter: Connatix #3601

Closed

AntoxaAntoxic added the do not port label Feb 25, 2025

osulzhenko assigned katherynhrabik Feb 25, 2025

katherynhrabik assigned kim-ng93 Feb 25, 2025

Net-burst changed the title ~~Port 3601 connatix adapter~~ Connatix: Port adapter from PBS-Go Feb 25, 2025

Net-burst changed the title ~~Connatix: Port adapter from PBS-Go~~ New adapter: Port Connatix adapter from PBS-Go Feb 25, 2025

requested changes

583e7ce

wrapping up changes and test fixes

764f2c4

AntoxaAntoxic reviewed Feb 27, 2025

View reviewed changes

last few updates

072c7bf

AntoxaAntoxic requested changes Feb 27, 2025

View reviewed changes

src/main/resources/bidder-config/connatix.yaml Outdated Show resolved Hide resolved

second support-cors

555dd26

AntoxaAntoxic previously approved these changes Feb 27, 2025

View reviewed changes

osulzhenko changed the title ~~New adapter: Port Connatix adapter from PBS-Go~~ Connatix: Port adapter from PBS-Go Feb 28, 2025

CTMBNara requested changes Mar 4, 2025

View reviewed changes

cleanup for requested changes

58a400a

kim-ng93 dismissed AntoxaAntoxic’s stale review via 58a400a March 4, 2025 23:54

CTMBNara approved these changes Mar 10, 2025

View reviewed changes

Merge branch 'prebid:master' into port-3601-connatix-adapter

a3b9983

CTMBNara merged commit 0944054 into prebid:master Mar 18, 2025
8 checks passed

karimMourra pushed a commit to karimMourra/prebid-server-java that referenced this pull request Apr 24, 2025

Connatix: Port adapter from PBS-Go (prebid#3781)

dd32ec0

Connatix: Port adapter from PBS-Go #3781

Connatix: Port adapter from PBS-Go #3781

Uh oh!

Conversation

katherynhrabik commented Feb 24, 2025

🔧 Type of changes

✨ What's the context?

🧠 Rationale behind the change

🔎 New Bid Adapter Checklist

🧪 Test plan

🏎 Quality check

Uh oh!

Uh oh!

Uh oh!

AntoxaAntoxic Feb 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

katherynhrabik commented Feb 26, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AntoxaAntoxic Feb 27, 2025

Choose a reason for hiding this comment

Uh oh!

CTMBNara Mar 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CTMBNara Mar 4, 2025

Choose a reason for hiding this comment

Uh oh!

CTMBNara Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CTMBNara Mar 4, 2025

Choose a reason for hiding this comment

Uh oh!

osulzhenko commented Mar 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

CTMBNara Mar 4, 2025 •

edited

Loading