Functional tests for prebid cache traceability #3763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osulzhenko
changed the title
…ests/prebid-cache-traceability
marki1an
requested changes
Feb 19, 2025
| import org.prebid.server.functional.model.response.auction.Adm | ||
| import org.prebid.server.functional.model.response.auction.BidResponse | ||
| import org.prebid.server.functional.util.PBSUtils | ||
| import spock.lang.IgnoreRest |
Collaborator
There was a problem hiding this comment.
Please remove redundant import
Comment on lines
23
to
34
| private final static String PBS_API_HEADER = 'x-pbc-api-key' | ||
| private static final Integer MAX_DATACENTER_REGION_LENGTH = 4 | ||
|
|
||
| private final static String XML_CREATIVE_SIZE_METRIC = "account.%s.prebid_cache.creative_size.xml" | ||
| private final static String JSON_CREATIVE_SIZE_METRIC = "account.%s.prebid_cache.creative_size.json" | ||
| private final static String XML_CREATIVE_TTL_METRIC = "account.%s.prebid_cache.creative_ttl.xml" | ||
| private final static String JSON_CREATIVE_TTL_METRIC = "account.%s.prebid_cache.creative_ttl.json" | ||
| private final static String CACHE_REQUEST_OK_METRIC = "account.%s.prebid_cache.requests.ok" | ||
| private final static String XML_CREATIVE_SIZE_GENERAL_METRIC = "prebid_cache.creative_size.xml" | ||
| private final static String JSON_CREATIVE_SIZE_GENERAL_METRIC = "prebid_cache.creative_size.json" | ||
| private final static String OK_GENERAL_METRIC = "prebid_cache.requests.ok" | ||
|
|
Collaborator
There was a problem hiding this comment.
Please use one order for all variables (like private static final TYPE NAME)
Collaborator
There was a problem hiding this comment.
We specified general metrics but not specified for accounts.
Maybe better to specify them
Comment on lines
163
to
165
| and: "Set bidder response" | ||
| def bidResponse = BidResponse.getDefaultBidResponse(bidRequest) | ||
| bidder.setResponse(bidRequest.id, bidResponse) |
Collaborator
There was a problem hiding this comment.
Do we need the bidder's response?
marki1an
requested changes
Feb 19, 2025
Comment on lines
173
to
174
| and: "PBS cache key should have length equal to default UUID" | ||
| assert cacheKey.length() == UUID.randomUUID().toString().length() |
Collaborator
There was a problem hiding this comment.
Maybe it's better to specify certain values for the length instead of generating them each time?
| def pbsService = pbsServiceFactory.getService(pbsConfig) | ||
|
|
||
| and: "Default BidRequest with cache, targeting and large account ID" | ||
| def bidRequest = BidRequest.defaultBidRequest |
Collaborator
There was a problem hiding this comment.
I hope it's almost a coding style for us to use tap.{} for bidRequest.
marki1an
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check