Core: Support seatnonbid Codes in Modules #3762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-codes-in-modules # Conflicts: # extra/modules/greenbids-real-time-data/src/main/java/org/prebid/server/hooks/modules/greenbids/real/time/data/v1/GreenbidsRealTimeDataProcessedAuctionRequestHook.java
osulzhenko
changed the title
…dules # Conflicts: # extra/modules/greenbids-real-time-data/src/main/java/org/prebid/server/hooks/modules/greenbids/real/time/data/config/GreenbidsRealTimeDataConfiguration.java # extra/modules/greenbids-real-time-data/src/main/java/org/prebid/server/hooks/modules/greenbids/real/time/data/core/GreenbidsInvocationService.java # extra/modules/ortb2-blocking/src/test/java/org/prebid/server/hooks/modules/ortb2/blocking/core/BidsBlockerTest.java # extra/modules/pb-richmedia-filter/src/test/java/org/prebid/server/hooks/modules/pb/richmedia/filter/core/BidResponsesMraidFilterTest.java # src/main/java/org/prebid/server/analytics/reporter/greenbids/GreenbidsAnalyticsReporter.java # src/main/java/org/prebid/server/auction/BidResponseCreator.java # src/main/java/org/prebid/server/auction/model/BidRejectionTracker.java # src/test/java/org/prebid/server/auction/BidResponseCreatorTest.java # src/test/java/org/prebid/server/auction/ExchangeServiceTest.java # src/test/java/org/prebid/server/auction/model/BidRejectionTrackerTest.java
CTMBNara
requested changes
Aug 27, 2025
...rver/hooks/modules/pb/richmedia/filter/v1/PbRichmediaFilterAllProcessedBidResponsesHook.java
Outdated
Show resolved
Hide resolved
| return CollectionUtils.isEmpty(accounts) || accounts.contains(account); | ||
| } | ||
|
|
||
| //todo: should it be more strict? e.g. allowing rejecting only imps/bids on the particular stages |
And1sS
requested changes
Sep 8, 2025
Comment on lines
138
to
145
| public Map<String, List<Rejected>> getAllRejected() { | ||
| final Map<String, List<Rejected>> missingImpIds = new HashMap<>(); | ||
| for (String impId : involvedImpIds) { | ||
| final Set<String> succeededBids = succeededBidsIds.getOrDefault(impId, Collections.emptySet()); | ||
| if (succeededBids.isEmpty() && !rejectedBids.containsKey(impId)) { | ||
| missingImpIds.computeIfAbsent(impId, key -> new ArrayList<>()) | ||
| .add(Pair.of(null, BidRejectionReason.NO_BID)); | ||
| .add(RejectedImp.of(impId, BidRejectionReason.NO_BID)); | ||
| } |
Collaborator
There was a problem hiding this comment.
This method is only used in tests. Please, remove
Collaborator
Author
There was a problem hiding this comment.
it's used in the analytics as well
...server/hooks/modules/greenbids/real/time/data/core/GreenbidsInvocationResultCreatorTest.java
Outdated
Show resolved
Hide resolved
...va/org/prebid/server/hooks/modules/greenbids/real/time/data/util/TestBidRequestProvider.java
Show resolved
Hide resolved
src/main/java/org/prebid/server/auction/model/BidRejectionTracker.java
Outdated
Show resolved
Hide resolved
| @Value(staticConstructor = "of") | ||
| public class RejectedBid implements Rejected { | ||
|
|
||
| BidderBid bid; |
Collaborator
There was a problem hiding this comment.
No need to store whole bid meta, can be simplified to:
@Accessors(fluent = true)
@Value(staticConstructor = "of")
public class RejectedBid implements Rejected {
String bidId;
String impId;
BidRejectionReason reason;
public static RejectedBid of(BidderBid bid, BidRejectionReason reason) {
return of(bid.getBid().getId(), bid.getBid().getImpid(), reason);
}
}
Collaborator
Author
There was a problem hiding this comment.
The whole bid might be needed for the analytics, because usually if a bid is rejected it's removed from the BidResponse, so this way the rejected bid is preserved.
CTMBNara
approved these changes
Sep 18, 2025
And1sS
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check