Skip to content

Insticator: fix video validation logic #3724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CTMBNara merged 4 commits into from
Feb 5, 2025
Merged

Insticator: fix video validation logic #3724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
09b56d1
Insticator: fix video validation logic
Net-burst Feb 4, 2025
749c2cb
update unit test
osulzhenko Feb 4, 2025
7fdb639
update unit test
osulzhenko Feb 4, 2025
27551df
fix code style
osulzhenko Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/prebid/server/bidder/insticator/InsticatorBidder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ private void validateImp(Imp imp) {

if (isInvalidDimension(video.getH())
|| isInvalidDimension(video.getW())
|| CollectionUtils.isNotEmpty(video.getMimes())) {
|| CollectionUtils.isEmpty(video.getMimes())) {

throw new PreBidException("One or more invalid or missing video field(s) w, h, mimes");
}
Expand Down
20 changes: 15 additions & 5 deletions src/test/java/org/prebid/server/bidder/insticator/InsticatorBidderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@

import java.math.BigDecimal;
import java.util.Arrays;
import java.util.Collections;
import java.util.List;
import java.util.Set;
import java.util.function.UnaryOperator;
Expand Down Expand Up @@ -449,11 +450,12 @@ public void makeHttpRequestsShouldMakeOneRequestWhenOneImpIsValidAndAnotherAreIn
final BidRequest bidRequest = givenBidRequest(
imp -> imp.id("givenImpId1").ext(mapper.valueToTree(ExtPrebid.of(null, mapper.createArrayNode()))),
imp -> imp.id("givenImpId2"),
imp -> imp.id("givenImpId3").video(Video.builder().mimes(null).build()),
imp -> imp.id("givenImpId4").video(Video.builder().h(null).build()),
imp -> imp.id("givenImpId5").video(Video.builder().h(0).build()),
imp -> imp.id("givenImpId6").video(Video.builder().w(null).build()),
imp -> imp.id("givenImpId7").video(Video.builder().w(0).build()));
imp -> imp.id("givenImpId3").video(givenVideo(video -> video.mimes(null))),
imp -> imp.id("givenImpId3").video(givenVideo(video -> video.mimes(Collections.emptyList()))),
imp -> imp.id("givenImpId4").video(givenVideo(video -> video.h(null))),
imp -> imp.id("givenImpId5").video(givenVideo(video -> video.h(0))),
imp -> imp.id("givenImpId6").video(givenVideo(video -> video.w(null))),
imp -> imp.id("givenImpId7").video(givenVideo(video -> video.w(0))));

//when
final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest);
Expand Down Expand Up @@ -569,6 +571,14 @@ private static Imp givenImp(UnaryOperator<Imp.ImpBuilder> impCustomizer) {
.build();
}

private static Video givenVideo(UnaryOperator<Video.VideoBuilder> videoCustomizer) {
return videoCustomizer.apply(Video.builder()
.mimes(List.of("video/mp4"))
.h(100)
.w(100))
.build();
}

private static ObjectNode givenImpExt(String adUnitId) {
return givenImpExt(adUnitId, "publisherId");
}
Expand Down
Loading