Kobler: New adapter ported from Go #3684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoxaAntoxic
requested changes
Jan 24, 2025
src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/spring/config/bidder/KoblerConfiguration.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java
Outdated
Show resolved
Hide resolved
AntoxaAntoxic
requested changes
Jan 30, 2025
Collaborator
AntoxaAntoxic
left a comment
AntoxaAntoxic
left a comment
There was a problem hiding this comment.
Ping me when you finish addressing the comments, probably this time I commented too early
src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java
Outdated
Show resolved
Hide resolved
AntoxaAntoxic
requested changes
Feb 7, 2025
src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/spring/config/bidder/KoblerConfiguration.java
Outdated
Show resolved
Hide resolved
AntoxaAntoxic
requested changes
Feb 10, 2025
src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/spring/config/bidder/KoblerConfiguration.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/kobler/KoblerBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/kobler/KoblerBidderTest.java
Outdated
Show resolved
Hide resolved
AntoxaAntoxic
previously approved these changes
Feb 14, 2025
src/test/java/org/prebid/server/bidder/kobler/KoblerBidderTest.java
Outdated
Show resolved
Hide resolved
CTMBNara
requested changes
Feb 14, 2025
src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/proto/openrtb/ext/request/kobler/ExtImpKobler.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/kobler/KoblerBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/kobler/KoblerBidderTest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/spring/config/bidder/KoblerConfiguration.java
Show resolved
Hide resolved
osulzhenko
changed the title
Collaborator
|
Required update based on the comments |
Contributor
|
@TommyHPettersen - heads up that we've ported this adapter from Go to Java. Also - noticed that the Prebid docs page https://docs.prebid.org/dev-docs/pbs-bidders.html#kobler doesn't list Prebid Server parameters, just PBJS params. Please consider updating https://github.com/prebid/prebid.github.io/blob/master/dev-docs/bidders/kobler.md with a note about PBS params -- I guess that there's no required param since you utilize referrer. thanks |
CTMBNara
requested changes
Apr 2, 2025
src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/kobler/KoblerBidder.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/kobler/KoblerBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/kobler/KoblerBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/kobler/KoblerBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/kobler/KoblerBidderTest.java
Outdated
Show resolved
Hide resolved
CTMBNara
requested changes
Apr 2, 2025
Comment on lines
201
to
239
| final Result<List<BidderBid>> result = target.makeBids(httpCall, BidRequest.builder().build()); | ||
|
|
||
| // then | ||
| assertThat(result.getErrors()).isEmpty(); | ||
| assertThat(result.getValue()) | ||
| .extracting(BidderBid::getType) | ||
| .containsExactly(BidType.banner); | ||
| } | ||
|
|
||
| @Test | ||
| public void makeBidsShouldReturnBannerWhenTypeIsNullOrMissing() throws JsonProcessingException { | ||
| // given | ||
| final Bid bid = Bid.builder() | ||
| .ext(mapper.valueToTree(Map.of("prebid", Map.of("type", "null")))) | ||
| .build(); | ||
|
|
||
| final BidderCall<BidRequest> httpCall = givenHttpCall(givenBidResponse(bid)); | ||
|
|
||
| // when | ||
| final Result<List<BidderBid>> result = target.makeBids(httpCall, BidRequest.builder().build()); | ||
|
|
||
| // then | ||
| assertThat(result.getErrors()).isEmpty(); | ||
| assertThat(result.getValue()) | ||
| .extracting(BidderBid::getType) | ||
| .containsExactly(BidType.banner); | ||
| } | ||
|
|
||
| @Test | ||
| public void makeBidsShouldDefaultToBannerWhenPrebidTypeIsMissing() throws JsonProcessingException { | ||
| // given | ||
| final Bid bid = Bid.builder() | ||
| .ext(mapper.valueToTree(Map.of("prebid", Map.of()))) | ||
| .build(); | ||
|
|
||
| final BidderCall<BidRequest> httpCall = givenHttpCall(givenBidResponse(bid)); | ||
|
|
||
| // when | ||
| final Result<List<BidderBid>> result = target.makeBids(httpCall, BidRequest.builder().build()); |
Collaborator
There was a problem hiding this comment.
Please remove unnecessary BidRequest objects. I have written comments about this in other places, but accidentally missed it in these tests.
CTMBNara
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
#3667