Skip to content

Conversation

@AntoxaAntoxic
Copy link
Collaborator

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes?

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@AntoxaAntoxic AntoxaAntoxic self-assigned this Jan 17, 2025
@AntoxaAntoxic AntoxaAntoxic added the do not merge Not the time for merging yet label Jan 17, 2025
@osulzhenko osulzhenko requested a review from CTMBNara January 26, 2025 13:21
@AntoxaAntoxic AntoxaAntoxic removed the do not merge Not the time for merging yet label Jan 29, 2025
CTMBNara
CTMBNara previously approved these changes Feb 4, 2025
@AntoxaAntoxic AntoxaAntoxic added the do not merge Not the time for merging yet label Feb 5, 2025
@AntoxaAntoxic AntoxaAntoxic removed the do not merge Not the time for merging yet label Feb 7, 2025
@osulzhenko osulzhenko requested a review from CTMBNara February 19, 2025 15:20
@CTMBNara CTMBNara merged commit 4323ae8 into master Feb 19, 2025
7 of 8 checks passed
@CTMBNara CTMBNara deleted the rubicon-bidder-apex-renderer-url branch February 19, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants