Skip to content

Conversation

@bretg
Copy link
Contributor

@bretg bretg commented Dec 19, 2024

🔧 Type of changes

  • github workflow

✨ What's the context?

Allow adapters and module owners to register for alerts when a PR is opened against their code. See prebid/prebid-server#4075

I tested this over in the sourcecred repo and have set up the config file just for Index Exchange at this point. Working on Prebid documentation for it.

@Net-burst Net-burst changed the title codepath alerts GitHub: codepath alerts Dec 20, 2024
@osulzhenko osulzhenko requested review from And1sS and CTMBNara and removed request for And1sS and CTMBNara December 20, 2024 14:42
const refreshToken = process.env.OAUTH2_REFRESH_TOKEN;

// validate params
if (!repo || !prNumber || !token || !clientId || !clientSecret | !refreshToken) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific reason for using a bitwise OR operator (|) for refreshToken? It seems like a logical OR (||) might be more appropriate for this comparison, as we're checking the presence of multiple variables.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@bretg bretg requested a review from osulzhenko January 2, 2025 14:48
@CTMBNara CTMBNara merged commit 23e9569 into master Jan 7, 2025
5 checks passed
@bretg
Copy link
Contributor Author

bretg commented Jan 7, 2025

@oronno - you may have noticed this already, but just in case, IX is the first entry in the codepath_notification file:

/ix|Ix|ix.json|ix.yaml: pdu-supply-prebid@indexexchange.com

@oronno
Copy link
Contributor

oronno commented Jan 8, 2025

@oronno - you may have noticed this already, but just in case, IX is the first entry in the codepath_notification file:

/ix|Ix|ix.json|ix.yaml: pdu-supply-prebid@indexexchange.com

Great. Thanks for implementing.

@bretg
Copy link
Contributor Author

bretg commented Jan 8, 2025

@oronno - I opened a test PR. You guys should have received email. The github workflow notification indicates it worked... please confirm?

Changed files: [ 'src/main/resources/bidder-config/ix.yaml' ]
Grouped matches by email: {
  'pdu-supply-prebid@indexexchange.com': [ 'src/main/resources/bidder-config/ix.yaml' ]
}
Email sent successfully to pdu-supply-prebid@indexexchange.com

@oronno
Copy link
Contributor

oronno commented Jan 8, 2025

@oronno - I opened a test PR. You guys should have received email. The github workflow notification indicates it worked... please confirm?

Changed files: [ 'src/main/resources/bidder-config/ix.yaml' ]
Grouped matches by email: {
  'pdu-supply-prebid@indexexchange.com': [ 'src/main/resources/bidder-config/ix.yaml' ]
}
Email sent successfully to pdu-supply-prebid@indexexchange.com

Confirmed it is working as expected. We received email in the mentioned address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants