-
Notifications
You must be signed in to change notification settings - Fork 224
Test: Transition PAAPI parameters
#3634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Corresponding issue prebid/prebid-server#3536 |
src/test/groovy/org/prebid/server/functional/tests/BidderParamsSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/model/config/AccountAuctionConfig.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/model/request/auction/AuctionEnvironment.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/model/request/auction/ImpExt.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/BidderParamsSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/bidder/openx/OpenxSpec.groovy
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/bidder/openx/OpenxSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/bidder/openx/OpenxSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/bidder/openx/OpenxSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/bidder/openx/OpenxSpec.groovy
Outdated
Show resolved
Hide resolved
|
Required update |
…ests/transition-PAAPI-parameters
…transition-PAAPI-parameters
…ests/transition-PAAPI-parameters
…ests/transition-PAAPI-parameters
osulzhenko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we additionaly should verify:
- that aliases can request both original and iab formats.
- that if impId from configs and impId from the response are mismatched (including wildcards), nothing happens.
- that warnings are issued in debug mode, alert.general metrics are emitted.
- that interestGroupAuctionBuyer is ignored when provided by a bidder.
- that the server defaults to the original format if ext.prebid.paaformat is not set or is invalid.
- ensure that empty igs or igi arrays do not cause crashes or errors.
src/test/groovy/org/prebid/server/functional/tests/bidder/openx/OpenxSpec.groovy
Show resolved
Hide resolved
osulzhenko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should also cover:
If there's no impid, then drop any igb objects from this entry. If any were dropped, mmit a warning in debug mode, log at N% sampling, and emit an alert.general metric.
and
Loop through the igb array
Add ext.bidder and ext.adapter to the igb entry
Add the igb entry to the global response entry
Rest is looking fine
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check