Skip to content

Fix #3581 declare PubMatic support for openRTB 2.6 #3623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CTMBNara merged 3 commits into from
Dec 17, 2024
Merged

Fix #3581 declare PubMatic support for openRTB 2.6 #3623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d64f60
Fix #3581 declare PubMatic support for openRTB 2.6
Dec 13, 2024
7ddac65
Fix #3581 adjusted pubmatic bid/auction requests in test
Dec 13, 2024
2bf71b6
Merge remote-tracking branch 'upstream/master' into port-3581-pubmati…
Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/resources/bidder-config/pubmatic.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
adapters:
pubmatic:
endpoint: https://hbopenbid.pubmatic.com/translator?source=prebid-server
ortb-version: "2.6"
meta-info:
maintainer-email: header-bidding@pubmatic.com
app-media-types:
Expand Down
4 changes: 1 addition & 3 deletions src/test/resources/org/prebid/server/it/openrtb2/pubmatic/test-auction-pubmatic-request.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,7 @@
],
"tmax": 5000,
"regs": {
"ext": {
"gdpr": 0
}
Comment on lines -52 to -54
Copy link
Contributor Author

@EmilNadimanov EmilNadimanov Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change and the one in test-pubmatic-bid-request.json i've peeked in many other commits that declared other bidders' support of openRTB 2.6

"gdpr": 0
},
"ext": {
"prebid": {
Expand Down
6 changes: 2 additions & 4 deletions src/test/resources/org/prebid/server/it/openrtb2/pubmatic/test-pubmatic-bid-request.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"h": 600
},
"tagid": "slot9",
"bidfloor" : 0.12,
"bidfloor": 0.12,
"ext": {
"ae": 1,
"pmZoneId": "Zone1,Zone2",
Expand Down Expand Up @@ -45,9 +45,7 @@
"USD"
],
"regs": {
"ext": {
"gdpr": 0
}
"gdpr": 0
},
"ext": {
"prebid": {
Expand Down
Loading