AGMA: Fix Nullpointer on empty auction context #3618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+120
to
+122
| if (auctionContext == null) { | ||
| return Future.succeededFuture(); | ||
| } |
Collaborator
There was a problem hiding this comment.
I'm not sure I know the case when auctionContext is null, because it should always be created for each auction
What's the case you've face to make this check?
Contributor
Author
There was a problem hiding this comment.
@AntoxaAntoxic as stated in the ticket this happens if a request tries to access a storedrequest that does not exist
Contributor
Author
There was a problem hiding this comment.
This does lead to this nullpointer:
prebid-server-1 | java.lang.NullPointerException: Cannot invoke "org.prebid.server.auction.model.AuctionContext.getBidRequest()" because "auctionContext" is null
prebid-server-1 | at org.prebid.server.analytics.reporter.agma.AgmaAnalyticsReporter.processEvent(AgmaAnalyticsReporter.java:119)
prebid-server-1 | at org.prebid.server.analytics.reporter.AnalyticsReporterDelegator.processEventByReporter(AnalyticsReporterDelegator.java:355)
prebid-server-1 | at org.prebid.server.analytics.reporter.AnalyticsReporterDelegator.lambda$delegateEvent$2(AnalyticsReporterDelegator.java:133)
prebid-server-1 | at io.vertx.core.impl.ContextInternal.dispatch(ContextInternal.java:279)
prebid-server-1 | at io.vertx.core.impl.ContextInternal.dispatch(ContextInternal.java:261)
prebid-server-1 | at io.vertx.core.impl.ContextInternal.lambda$runOnContext$0(ContextInternal.java:59)
prebid-server-1 | at io.netty.util.concurrent.AbstractEventExecutor.runTask(AbstractEventExecutor.java:173)
prebid-server-1 | at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:166)
prebid-server-1 | at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:470)
prebid-server-1 | at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:413)
prebid-server-1 | at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997)
prebid-server-1 | at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
prebid-server-1 | at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
prebid-server-1 | at java.base/java.lang.Thread.run(Thread.java:1583)
Collaborator
There was a problem hiding this comment.
Sorry, I've skipped the description)
Yeah, I see. Interesting.
AntoxaAntoxic
approved these changes
Dec 12, 2024
Contributor
|
Wow! Good catch @steffenmllr . We are going to deploy this soon for the three big german verzeichnisse |
muuki88
approved these changes
Dec 12, 2024
CTMBNara
approved these changes
Dec 16, 2024
Contributor
|
@steffenmllr - does this fix need to be ported to PBS-Go? |
Contributor
Author
|
@bretg thanks for asking! this was a java specific bug so there is no need to port this |
sergseven
pushed a commit
to openx/prebid-server-java
that referenced
this pull request
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
We got reports that using non existing Stored Requests / Impressions leads to a Nullpointer