Test: consented_providers_settings
#3577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osulzhenko
previously approved these changes
Nov 26, 2024
…for-consented_providers_settings-field
osulzhenko
requested changes
Dec 3, 2024
| assert bidderRequest.user.ext.consentedProvidersSettings.consentedProviders == randomAddtlConsent | ||
| } | ||
|
|
||
| def "PBS should leave requested user.ext.{consented_providers_settings/ConsentedProvidersSettings}.consented_providers as is"() { |
Collaborator
There was a problem hiding this comment.
PBS should process original user.ext.{consented_providers_settings/ConsentedProvidersSettings}.consented_providers when ampRequest doesn't contain addtl_consent
| UserExtPrebid prebid | ||
| ConsentedProvidersSettings consentedProvidersSettings | ||
| @JsonProperty("ConsentedProvidersSettings") | ||
| ConsentedProvidersSettings consentedProvidersSettingsKebabCase |
Collaborator
There was a problem hiding this comment.
ConsentedProvidersSettings consentedProvidersSettingsCamelCase
| assert bidderRequest.user.ext.consentedProvidersSettings.consentedProviders == consentProviders | ||
| } | ||
|
|
||
| def "PBS shouldn't pass addtl_consent to user.ext.{consented_providers_settings/ConsentedProvidersSettings}.consented_providers"() { |
Collaborator
There was a problem hiding this comment.
PBS should left user.ext.{consented_providers_settings/ConsentedProvidersSettings}.consented_providers empty when addtl_consent and original fields are empty
osulzhenko
approved these changes
Dec 4, 2024
sergseven
pushed a commit
to openx/prebid-server-java
that referenced
this pull request
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes? Are there any
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check