Skip to content

Modules: AB testing #3576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CTMBNara merged 19 commits into from
Dec 4, 2024
Merged

Modules: AB testing #3576

CTMBNara merged 19 commits into from
Dec 4, 2024

Conversation

@CTMBNara
Copy link
Collaborator

@CTMBNara CTMBNara commented Nov 22, 2024

🔧 Type of changes

  • new bid adapter
  • update bid adapter
  • new feature
  • new analytics adapter
  • new module
  • bugfix
  • documentation
  • configuration
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes? Are there any

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hosts
  • geographic host parameters are NOT required
  • NO direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@CTMBNara CTMBNara requested a review from And1sS November 22, 2024 23:46
And1sS
And1sS requested changes Nov 27, 2024
View reviewed changes
@CTMBNara CTMBNara requested a review from And1sS November 27, 2024 14:13
And1sS
And1sS previously approved these changes Nov 27, 2024
View reviewed changes
@CTMBNara CTMBNara marked this pull request as ready for review December 2, 2024 19:07
@CTMBNara CTMBNara requested a review from And1sS December 2, 2024 19:07
CTMBNara and others added 2 commits December 2, 2024 20:13
And1sS
And1sS previously approved these changes Dec 4, 2024
View reviewed changes
@CTMBNara
Merge remote-tracking branch 'origin/master' into modules/ab-testing
9fd4347 
# Conflicts:
#	src/main/java/org/prebid/server/hooks/execution/GroupExecutor.java
#	src/main/java/org/prebid/server/hooks/execution/HookStageExecutor.java
#	src/main/java/org/prebid/server/hooks/execution/StageExecutor.java
#	src/test/groovy/org/prebid/server/functional/tests/module/GeneralModuleSpec.groovy
@CTMBNara
Fix merge issues.
6514977
@CTMBNara CTMBNara merged commit d74e387 into master Dec 4, 2024
6 of 7 checks passed
@CTMBNara CTMBNara deleted the modules/ab-testing branch December 4, 2024 16:21
@cross-repo-issue-creation cross-repo-issue-creation bot mentioned this pull request Dec 4, 2024
Closed
sergseven pushed a commit to openx/prebid-server-java that referenced this pull request Dec 23, 2024
@CTMBNara @sergseven
Modules: AB testing (prebid#3576)
b25cd09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@osulzhenko osulzhenko osulzhenko approved these changes

@And1sS And1sS And1sS left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CTMBNara @And1sS @osulzhenko