Core: granular settings for main thread yielding - Seeking Quantitative Testers

[dgirardi]

Type of change

• Bugfix

A set of fixes addressing poor performance of 10 in various tests:

• Turn off main thread yielding by default, and allows enabling it separately for renderAd and processQueue.
• update rendering logic so that it doesn't need GreedyPromise to avoid yielding;

Updated with:

• a simple pbjs.yield flag that can turn off yielding during processQueue (defaults to on);
• a setConfig({auctionOptions: {legacyRender: true}}) option (defaults to false) that, when enabled:
  • disables yielding during pbjs.renderAd;
  • reverts to pre-10.12 rendering logic (document.write instead of the extra iframe)

We're seeking an entity to give quantitative feedback on this branch.

[github-actions]

Tread carefully! This PR adds 3 linter errors (possibly disabled through directives):

• test/spec/unit/pbjs_api_spec.js (+3 errors)

[github-actions]

Tread carefully! This PR adds 3 linter errors (possibly disabled through directives):

• test/spec/unit/pbjs_api_spec.js (+3 errors)

[github-actions]

Tread carefully! This PR adds 1 linter error (possibly disabled through directives):

• src/prebid.ts (+1 error)

[coveralls]

Pull Request Test Coverage Report for Build 19938887501

Details

• 181 of 186 (97.31%) changed or added relevant lines in 11 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.002%) to 96.21%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
modules/topLevelPaapi.js	11	12	91.67%
src/adRendering.ts	16	17	94.12%
src/prebid.ts	10	11	90.91%
src/config.ts	22	24	91.67%

Totals
Change from base Build 19900522067:	0.002%
Covered Lines:	205189
Relevant Lines:	213272

---

💛 - Coveralls

[patmmccann]

marking do not merge while we continue to seek large companies to test this idea

[dgirardi]

Updated with:

• a simple pbjs.yield flag that can turn off yielding during processQueue (defaults to on);
• a setConfig({auctionOptions: {legacyRender: true}}) option (defaults to false) that, when enabled:
  • disables yielding during pbjs.renderAd;
  • reverts to pre-10.12 rendering logic (document.write instead of the extra iframe)