Skip to content

Modify 'cuh' extension types in extensions.py#584

Closed
HagegeR wants to merge 1 commit intopre-commit:mainfrom
HagegeR:patch-1
Closed

Modify 'cuh' extension types in extensions.py#584
HagegeR wants to merge 1 commit intopre-commit:mainfrom
HagegeR:patch-1

Conversation

@HagegeR
Copy link

@HagegeR HagegeR commented Mar 16, 2026

Updated the 'cuh' extension to include 'header' as a type.

Updated the 'cuh' extension to include 'header' as a type.
@asottile
Copy link
Member

generally a best practice in open source is to look at the original change and figure out why it is the way it is

@asottile asottile closed this Mar 16, 2026
@HagegeR
Copy link
Author

HagegeR commented Mar 16, 2026

I did not see any docs/issues saying why it could not be done, could you point me to one?

you would say the best way to target header files in general, including cuda ones would be to use something like:
files: \.(h|hpp|hh|hxx|cuh)$

@asottile
Copy link
Member

did you find the original patch?

@HagegeR
Copy link
Author

HagegeR commented Mar 16, 2026

Thanks @asottile, I did...
But I think that any ecosystem is changing over time, and that if you'd look at any current CUDA documentation, cuh file type is considered a CUDA C++ header file.

Would you reconsider accordingly?
https://forums.developer.nvidia.com/t/whats-the-difference-between-cuh-and-h/266214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants