Modify 'cuh' extension types in extensions.py#584
Closed
HagegeR wants to merge 1 commit intopre-commit:mainfrom
Closed
Modify 'cuh' extension types in extensions.py#584HagegeR wants to merge 1 commit intopre-commit:mainfrom
HagegeR wants to merge 1 commit intopre-commit:mainfrom
Conversation
Updated the 'cuh' extension to include 'header' as a type.
Member
|
generally a best practice in open source is to look at the original change and figure out why it is the way it is |
Author
|
I did not see any docs/issues saying why it could not be done, could you point me to one? you would say the best way to target header files in general, including cuda ones would be to use something like: |
Member
|
did you find the original patch? |
Author
|
Thanks @asottile, I did... Would you reconsider accordingly? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the 'cuh' extension to include 'header' as a type.