Add native implementations for Keccak on Armv8.1-m#511
Conversation
mkannwischer
left a comment
mkannwischer
left a comment
There was a problem hiding this comment.
Thanks @bremoran! We'll need to discuss this with the others. Here are some initial comments.
I don't see this test being exercised in the MVE CI so far. That definitely should be changed.
We should align the test names with mlkem-native.
My biggest concern right now is uniform licensing. At least everything in mldsa/ needs to be Apache-2.0 OR ISC OR MIT. For test/ we may be slightly more flexible, but just having Apache-2.0 OR ISC OR MIT for everything makes it less confusing. For code that is public domain/CC0 relicensing should be easy.
mldsa/fips202/keccakf1600.c
Outdated
| unsigned i; | ||
| #if defined(MLD_SYS_LITTLE_ENDIAN) | ||
| #if defined(MLD_USE_FIPS202_X1_NATIVE) | ||
| (void) i; |
There was a problem hiding this comment.
remove this and move the unsigned i inside of the other block instead.
Makefile
Outdated
| # SPDX-License-Identifier: Apache-2.0 OR ISC OR MIT | ||
|
|
||
| .PHONY: func kat acvp stack \ | ||
| .PHONY: func kat acvp stack keccak \ |
There was a problem hiding this comment.
Can we use the same naming as in mlkem-native and call this unit: https://github.com/pq-code-package/mlkem-native/blob/9ae2223e835c1abcc8d6857dd3b7f8ce00a05216/Makefile#L84?
If we can keep the diff to mlkem-native minimal that would be appreciated.
There was a problem hiding this comment.
Yes, I will attempt to set this up more like the unit test framework in mlkem-native.
bremoran
force-pushed
the
armv8.1-m-native
branch
3 times, most recently
from
d45104c to
46ca703
Compare
|
@hanno-becker Does your comment in pq-code-package/mlkem-native#1224 apply here? |
bremoran
force-pushed
the
armv8.1-m-native
branch
from
fd0b14d to
4d5d95a
Compare
Add unit tests for FIPS202 APIs Add unit tests for x4 keccak Add support for benchmarking on mps3 Signed-off-by: Brendan Moran <brendan.moran@arm.com>
bremoran
force-pushed
the
armv8.1-m-native
branch
from
196645a to
64807d8
Compare
mkannwischer
left a comment
mkannwischer
left a comment
There was a problem hiding this comment.
Thanks @bremoran! I'm very sorry for the long silence on this PR.
Could you please split this up into 3 smaller PRs:
(1) Add benchmarking for Armv8-M
(2) Add the unit tests for Keccak
(3) Add the native MVE Keccak
2 participants
Also add tests for Keccak implementations on Armv8.1-m