Adding build script for docling-parse pkg #7703
Open
+322
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>
Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>
Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>
Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>
Author
|
@shubham-dayma-ibm PTAL |
yussufsh
reviewed
Jan 20, 2026
d/docling-parse/build_info.json
Outdated
| "docker_build": false, | ||
| "validate_build_script": true, | ||
| "use_non_root_user": "false", | ||
| "v4.7.1":{ |
Contributor
There was a problem hiding this comment.
Suggested change
| "v4.7.1":{ | |
| "*":{ |
Let's set it to use same build script for all versions. In case in future it fails we can set specific versions.
yussufsh
reviewed
Jan 20, 2026
| OS_NAME=$(grep ^PRETTY_NAME /etc/os-release | cut -d= -f2) | ||
| SOURCE=Github | ||
| # Install pillow | ||
| PILLOW_VERSION=11.2.1 |
Contributor
There was a problem hiding this comment.
I am skeptical about hardcoding a version for a dependency. Can we not use the devpi index and let it choose which version to install from the available list during runtime while installing docling-parse?
Author
There was a problem hiding this comment.
when we use pre built wheel from devpi, one of the test case of docling-parse pkg is falling
Author
There was a problem hiding this comment.
removed steps to build pillow. PTAL
Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>
Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>
Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>
rcarino5
requested review from
nikhil-kalbande,
shubham-dayma-ibm and
yussufsh
Contributor
|
Reviewers please assist with this PR. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
set -eoption enabled and observe success ?