Lab 1 sonarcloud.yml

.github/workflows/coverlet.msbuild

@@ -0,0 +1,3 @@
+dotnet add NetSdrClientAppTests package coverlet.msbuild
+dotnet add NetSdrClientAppTests package Microsoft.NET.Test.Sdk
+dotnet test NetSdrClientAppTests -c Release       /p:CollectCoverage=true       /p:CoverletOutput=TestResults/coverage.xml       /p:CoverletOutputFormat=opencover

.github/workflows/sonarcloud.yml

@@ -1,83 +1,92 @@
-# This workflow uses actions that are not certified by GitHub.
-# They are provided by a third-party and are governed by
-# separate terms of service, privacy policy, and support
-# documentation.
-
-# This workflow helps you trigger a SonarCloud analysis of your code and populates
-# GitHub Code Scanning alerts with the vulnerabilities found.
-# Free for open source project.
-
-# 1. Login to SonarCloud.io using your GitHub account
-
-# 2. Import your project on SonarCloud
-#     * Add your GitHub organization first, then add your repository as a new project.
-#     * Please note that many languages are eligible for automatic analysis,
-#       which means that the analysis will start automatically without the need to set up GitHub Actions.
-#     * This behavior can be changed in Administration > Analysis Method.
-#
-# 3. Follow the SonarCloud in-product tutorial
-#     * a. Copy/paste the Project Key and the Organization Key into the args parameter below
-#          (You'll find this information in SonarCloud. Click on "Information" at the bottom left)
-#
-#     * b. Generate a new token and add it to your Github repository's secrets using the name SONAR_TOKEN
-#          (On SonarCloud, click on your avatar on top-right > My account > Security
-#           or go directly to https://sonarcloud.io/account/security/)
-
-# Feel free to take a look at our documentation (https://docs.sonarcloud.io/getting-started/github/)
-# or reach out to our community forum if you need some help (https://community.sonarsource.com/c/help/sc/9)
-
-name: SonarCloud analysis
+name: SonarCloud Analysis
 
 on:
   push:
     branches: [ "master" ]
   pull_request:
     branches: [ "master" ]
-  workflow_dispatch:
-
-permissions:
-  pull-requests: read # allows SonarCloud to decorate PRs with analysis results
 
 jobs:
-  sonar-check:
-    name: Sonar Check
-    runs-on: windows-latest   # безпечно для будь-яких .NET проектів
+  build-and-analyze:
+    name: Build and Analyze
+    runs-on: windows-latest
+
     steps:
-      - uses: actions/checkout@v4
-        with: { fetch-depth: 0 }
-
-      - uses: actions/setup-dotnet@v4
-        with:
-          dotnet-version: '8.0.x'
-
-      # 1) BEGIN: SonarScanner for .NET
-      - name: SonarScanner Begin
-        run: |
-          dotnet tool install --global dotnet-sonarscanner
-          echo "$env:USERPROFILE\.dotnet\tools" >> $env:GITHUB_PATH
-          dotnet sonarscanner begin `
-          /k:"ppanchen_NetSdrClient" `
-          /o:"ppanchen" `
-          /d:sonar.token="${{ secrets.SONAR_TOKEN }}" `
-          /d:sonar.cs.opencover.reportsPaths="**/coverage.xml" `
+    - name: Checkout code
+      uses: actions/checkout@v4
+
+    - name: Setup .NET
+      uses: actions/setup-dotnet@v3
+      with:
+        dotnet-version: '6.0.x'
+
+    - name: Install SonarScanner
+      run: |
+        dotnet tool install --global dotnet-sonarscanner
+        echo "$env:USERPROFILE\.dotnet\tools" >> $env:GITHUB_PATH
+
+    - name: Install Coverlet
+      run: dotnet tool install --global coverlet.console
+
+    - name: Build and test with SonarCloud
+      env:
+        SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+      run: |
+        # Start SonarScanner
+        dotnet sonarscanner begin `
+          /k:"Yegres546_NetSdrClient" `
+          /o:"yegres546" `
+          /d:sonar.token="$env:SONAR_TOKEN" `
+          /d:sonar.cs.opencover.reportsPaths="**/coverage.opencover.xml" `
           /d:sonar.cpd.cs.minimumTokens=40 `
           /d:sonar.cpd.cs.minimumLines=5 `
-          /d:sonar.exclusions=**/bin/**,**/obj/**,**/sonarcloud.yml `
+          /d:sonar.exclusions="**/bin/**,**/obj/**,**/TestResults/**,**/*.Tests.cs" `
+          /d:sonar.coverage.exclusions="**Test*.cs" `
           /d:sonar.qualitygate.wait=true
-        shell: pwsh
-      # 2) BUILD & TEST
-      - name: Restore
-        run: dotnet restore NetSdrClient.sln
-      - name: Build
-        run: dotnet build NetSdrClient.sln -c Release --no-restore
-      #- name: Tests with coverage (OpenCover)
-      #  run: |
-      #    dotnet test NetSdrClientAppTests/NetSdrClientAppTests.csproj -c Release --no-build `
-      #      /p:CollectCoverage=true `
-      #      /p:CoverletOutput=TestResults/coverage.xml `
-      #      /p:CoverletOutputFormat=opencover
-      #  shell: pwsh
-      # 3) END: SonarScanner
-      - name: SonarScanner End
-        run: dotnet sonarscanner end /d:sonar.token="${{ secrets.SONAR_TOKEN }}"
-        shell: pwsh
+
+        # Build the solution
+        dotnet build --configuration Release
+
+        # Run tests with coverage
+        dotnet test --configuration Release `
+          --no-build `
+          --verbosity normal `
+          --collect:"XPlat Code Coverage" `
+          --results-directory ./TestResults `
+          -- DataCollectionRunSettings.DataCollectors.DataCollector.Configuration.Format=opencover
+
+        # End SonarScanner
+        dotnet sonarscanner end /d:sonar.token="$env:SONAR_TOKEN"
+name: Architecture Rules Validation
+
+on:
+  push:
+    branches: [ "lab5" ]
+  pull_request:
+    branches: [ "lab5" ]
+
+jobs:
+  architecture-tests:
+    name: Architecture Rules Validation
+    runs-on: windows-latest
+
+    steps:
+    - name: Checkout code
+      uses: actions/checkout@v4
+
+    - name: Setup .NET
+      uses: actions/setup-dotnet@v3
+      with:
+        dotnet-version: '6.0.x'
+
+    - name: Install dependencies
+      run: dotnet restore
+
+    - name: Build
+      run: dotnet build --no-restore --configuration Release
+
+    - name: Run Architecture Tests
+      run: dotnet test --configuration Release --no-build --verbosity normal --filter "Category=Architecture"
+
+    - name: Run All Tests
+      run: dotnet test --configuration Release --no-build --verbosity normal

EchoTcpServer/Program.cs

@@ -47,7 +47,7 @@ public async Task StartAsync()
         Console.WriteLine("Server shutdown.");
     }
 
-    private async Task HandleClientAsync(TcpClient client, CancellationToken token)
+    private static async Task HandleClientAsync(TcpClient client, CancellationToken token)
     {
         using (NetworkStream stream = client.GetStream())
         {
@@ -112,21 +112,22 @@ public static async Task Main(string[] args)
     }
 }
 
-
-public class UdpTimedSender : IDisposable
+namespace EchoServerNamespace
 {
-    private readonly string _host;
-    private readonly int _port;
-    private readonly UdpClient _udpClient;
-    private Timer _timer;
-
-    public UdpTimedSender(string host, int port)
+    public class UdpTimedSender : IDisposable
     {
-        _host = host;
-        _port = port;
-        _udpClient = new UdpClient();
-    }
+        private readonly string _host;
+        private readonly int _port;
+        private readonly UdpClient _udpClient;
+        private Timer _timer;
 
+        public UdpTimedSender(string host, int port)
+        {
+            _host = host;
+            _port = port;
+            _udpClient = new UdpClient();
+        }
+    }
     public void StartSending(int intervalMilliseconds)
     {
         if (_timer != null)
@@ -170,4 +171,4 @@ public void Dispose()
         StopSending();
         _udpClient.Dispose();
     }
-}
+}

Infrastructure/DatabaseService.cs

@@ -0,0 +1,10 @@
+namespace NetSdrClient.Infrastructure
+{
+    public class DatabaseService
+    {
+        public void SaveData(object data)
+        {
+            // Database operations
+        }
+    }
+}

Interfaces/IDeviceService.cs

@@ -0,0 +1,8 @@
+namespace NetSdrClient.Interfaces
+{
+    public interface IDeviceService
+    {
+        void Connect();
+        void Disconnect();
+    }
+}

NetSdrClient.Tests/ArchitectureTests.cs

@@ -0,0 +1,148 @@
+using NetArchTest.Rules;
+using Microsoft.VisualStudio.TestTools.UnitTesting;
+
+namespace NetSdrClient.Tests
+{
+    [TestClass]
+    public class ArchitectureTests
+    {
+        private const string ApplicationNamespace = "NetSdrClient";
+        private const string ModelsNamespace = "NetSdrClient.Models";
+        private const string ServicesNamespace = "NetSdrClient.Services";
+        private const string InterfacesNamespace = "NetSdrClient.Interfaces";
+        private const string InfrastructureNamespace = "NetSdrClient.Infrastructure";
+        private const string UINamespace = "NetSdrClient.UI";
+
+        [TestMethod]
+        public void ServicesLayer_ShouldNotDependOnUI()
+        {
+            // Arrange
+            var assembly = typeof(Services.SDRClient).Assembly;
+
+            // Act
+            var result = Types
+                .InAssembly(assembly)
+                .That()
+                .ResideInNamespace(ServicesNamespace)
+                .ShouldNot()
+                .HaveDependencyOn(UINamespace)
+                .GetResult();
+
+            // Assert
+            Assert.IsTrue(result.IsSuccessful, 
+                $"Services layer should not depend on UI: {string.Join(", ", result.FailingTypes)}");
+        }
+
+        [TestMethod]
+        public void Models_ShouldNotReferenceServices()
+        {
+            // Arrange
+            var assembly = typeof(Models.SDRDevice).Assembly;
+
+            // Act
+            var result = Types
+                .InAssembly(assembly)
+                .That()
+                .ResideInNamespace(ModelsNamespace)
+                .ShouldNot()
+                .HaveDependencyOn(ServicesNamespace)
+                .GetResult();
+
+            // Assert
+            Assert.IsTrue(result.IsSuccessful,
+                $"Models should not depend on Services: {string.Join(", ", result.FailingTypes)}");
+        }
+
+        [TestMethod]
+        public void Interfaces_ShouldNotHaveDependencies()
+        {
+            // Arrange
+            var assembly = typeof(Services.SDRClient).Assembly;
+
+            // Act
+            var result = Types
+                .InAssembly(assembly)
+                .That()
+                .ResideInNamespace(InterfacesNamespace)
+                .Should()
+                .NotHaveDependencyOnAny(
+                    ServicesNamespace,
+                    ModelsNamespace,
+                    InfrastructureNamespace,
+                    UINamespace)
+                .GetResult();
+
+            // Assert
+            Assert.IsTrue(result.IsSuccessful,
+                $"Interfaces should not have dependencies: {string.Join(", ", result.FailingTypes)}");
+        }
+
+        [TestMethod]
+        public void AllClasses_ShouldHaveNamesEndingWithService_IfInServicesNamespace()
+        {
+            // Arrange
+            var assembly = typeof(Services.SDRClient).Assembly;
+
+            // Act
+            var result = Types
+                .InAssembly(assembly)
+                .That()
+                .ResideInNamespace(ServicesNamespace)
+                .And()
+                .AreClasses()
+                .Should()
+                .HaveNameEndingWith("Service")
+                .Or()
+                .HaveNameEndingWith("Client")
+                .Or()
+                .HaveNameEndingWith("Handler")
+                .GetResult();
+
+            // Assert
+            Assert.IsTrue(result.IsSuccessful,
+                $"Services should have proper naming: {string.Join(", ", result.FailingTypes)}");
+        }
+
+        [TestMethod]
+        public void Models_ShouldBeSealed()
+        {
+            // Arrange
+            var assembly = typeof(Models.SDRDevice).Assembly;
+
+            // Act
+            var result = Types
+                .InAssembly(assembly)
+                .That()
+                .ResideInNamespace(ModelsNamespace)
+                .And()
+                .AreClasses()
+                .Should()
+                .BeSealed()
+                .GetResult();
+
+            // Assert
+            Assert.IsTrue(result.IsSuccessful,
+                $"Models should be sealed: {string.Join(", ", result.FailingTypes)}");
+        }
+
+        [TestMethod]
+        public void Services_ShouldNotDependOnInfrastructureDirectly()
+        {
+            // Arrange
+            var assembly = typeof(Services.SDRClient).Assembly;
+
+            // Act
+            var result = Types
+                .InAssembly(assembly)
+                .That()
+                .ResideInNamespace(ServicesNamespace)
+                .ShouldNot()
+                .HaveDependencyOn(InfrastructureNamespace)
+                .GetResult();
+
+            // Assert
+            Assert.IsTrue(result.IsSuccessful,
+                $"Services should not depend directly on Infrastructure: {string.Join(", ", result.FailingTypes)}");
+        }
+    }
+}