Check AppContext.BaseDirectory for powersync.dll
#28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14 by checking the application's base directory for
powersync.dll.Applications packaged via a Windows Application Packaging project are flattened to have all DLLs placed in the same directory. Currently, PowerSync.Common only checks
<approot>/runtimes/<rid>/native/powersync.dll, which doesn't exist in packaged apps due to the aforementioned DLL flattening. This PR adds a check to see if it can findpowersync.dllin the root folder and if so, loads that DLL instead of theruntimes/<rid>/nativeone.