This repository was archived by the owner on Jul 10, 2024. It is now read-only.
Draft
Conversation
Signed-off-by: versilis <versilis@akitasoftware.com>
Signed-off-by: versilis <versilis@akitasoftware.com>
Signed-off-by: versilis <versilis@akitasoftware.com>
Signed-off-by: versilis <versilis@akitasoftware.com>
Co-authored-by: Mark Gritter <mgritter@akitasoftware.com>
This provides a workaround to remove all telemetry info logs during a command's initialization. This is needed by the kube secret command because only the raw YAML output should be printed to stdout.
versilis
force-pushed
the
versilis/kube-secret-with-api
branch
2 times, most recently
from
83aaf74 to
64f0125
Compare
versilis
force-pushed
the
versilis/kube-secret-with-api
branch
from
64f0125 to
3d5e896
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses a code review suggestion to use the Kubernetes API for generation of secret files when using
akita kube secret.Unfortunately, Kubernetes' current Go API contains an
ObjectMetamodel that is in misalignment with Kubernetes' open api spec. As a workaround, I've added logic to manually fix the incorrect field (CreationTimestamp) after serialization.