refactor(server): improve statement timeout and parameter handling#910
Open
tjhanley wants to merge 1 commit intopostgresml:mainfrom
Open
refactor(server): improve statement timeout and parameter handling#910tjhanley wants to merge 1 commit intopostgresml:mainfrom
tjhanley wants to merge 1 commit intopostgresml:mainfrom
Conversation
8f6fa26 to
bc4f28a
Compare
- Add statement timeout configuration at pool level (pools.<pool_name>.statement_timeout) - Add logging for statement timeout configuration during pool initialization - Improve sync_parameters method to handle statement timeout consistently - Document statement timeout configuration in CONFIG.md - Change string initialization from String::from() to String::new() - Maintain cleanup state until connection check-in for proper connection pooling The statement timeout setting leverages PostgreSQL's native statement_timeout parameter, allowing the database to handle query termination automatically. This ensures reliable timeout enforcement directly at the database level, rather than managing timeouts in the connection pooler. Pool-level settings take precedence over user-level settings for consistent timeout enforcement across all pool users.
bc4f28a to
412bf4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The statement timeout setting leverages PostgreSQL's native statement_timeout parameter, allowing the database to handle query termination automatically. This ensures reliable timeout enforcement directly at the database level, rather than managing timeouts in the connection pooler. Pool-level settings take precedence over user-level settings for consistent timeout enforcement across all pool users.
Connecting to the Postgres instance through PGCat connection pooler.
Minimal Config
Removing the option from the configuration yields this in the config.