Skip to content

e2e: Assistant fix for model picker not showing#12353

Merged
jonvanausdeln merged 5 commits intomainfrom
jonv-e2e-assistant-flake-fix
Mar 10, 2026
Merged

e2e: Assistant fix for model picker not showing#12353
jonvanausdeln merged 5 commits intomainfrom
jonv-e2e-assistant-flake-fix

Conversation

@jonvanausdeln
Copy link
Copy Markdown
Contributor

@jonvanausdeln jonvanausdeln commented Mar 6, 2026

With the 1.109 merge, the model picker can now end up in an overflow menu, causing tests to fail.

  • Switched to using a keyboard shortcut to open model picker, by-passing the overflow
  • Removed the check for enabled tests as many other will fail if that's not working, so it's not needed.

QA Notes

@:assistant @:assistant-eval

@jonvanausdeln jonvanausdeln self-assigned this Mar 6, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 6, 2026

E2E Tests 🚀
This PR will run tests tagged with: @:critical @:assistant @:assistant-eval

readme  valid tags

@jonvanausdeln jonvanausdeln changed the title Jonv-e2e-assistant-flake-fix e2e: Assistant fix for model picker not showing Mar 6, 2026
@jonvanausdeln jonvanausdeln marked this pull request as ready for review March 6, 2026 22:18
testlabauto
testlabauto previously approved these changes Mar 6, 2026
Copy link
Copy Markdown
Contributor

@testlabauto testlabauto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@testlabauto testlabauto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonvanausdeln jonvanausdeln merged commit 7001d93 into main Mar 10, 2026
21 checks passed
@jonvanausdeln jonvanausdeln deleted the jonv-e2e-assistant-flake-fix branch March 10, 2026 14:56
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants