fix(pkg-py): metadata.columns now returns internal positional names#170
Merged
cpsievert merged 1 commit intoposit-dev:mainfrom Mar 4, 2026
Merged
Conversation
cpsievert
changed the title
cpsievert
force-pushed
the
fix/metadata-columns-regression
branch
from
1fdbe61 to
196350e
Compare
The metadata.columns field reflects internal ggsql spec details that are still evolving. The Python test should verify the structure (list, non-empty) without asserting specific column names. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
cpsievert
force-pushed
the
fix/metadata-columns-regression
branch
from
196350e to
1467dfa
Compare
cpsievert
changed the title
cpsievert
changed the title
metadata.columns now returns internal positional names
Collaborator
|
TBH I'm not entirely sure what the contract is with metadata. It is true that the internal representation of positional aesthetics are now coordinate system agnostic but perhaps this should be changed back when fetching the metadata? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a python test that started failing after #151 -- which resulted in
metadata.columnsreturningpos1/pos2instead ofx/y. Just checking, is that intentional @thomasp85?Either way, I think it probably makes the most sense to scale the Python test back to not dig into the specification so deeply.