Skip to content

run integration tests nightly#516

Merged
jonkeane merged 3 commits intomainfrom
kara-nightly-integration-tests
Mar 7, 2026
Merged

run integration tests nightly#516
jonkeane merged 3 commits intomainfrom
kara-nightly-integration-tests

Conversation

@karawoo
Copy link
Collaborator

@karawoo karawoo commented Mar 6, 2026

Intent

Runs integration tests on a nightly schedule in addition to on PRs. Since the integration tests include preview builds, this should help us catch cases when upcoming changes in Connect will break connectapi so we can quickly fix them.

Approach

Add a schedule trigger. If integration tests fail, we'll send a slack notification. Note I'm still waiting on a webhook so that part of things won't work yet until I get it and can create the appropriate repository secret.

Checklist

  • Does this change update NEWS.md (referencing the connected issue if necessary)?
  • Does this change need documentation? Have you run devtools::document()?
  • Does this change resolve integration test failures for a preview build of Connect? If so (and if you are on the Connect team), please be sure to update the Connect changelog to reflect that users will need to upgrade their version of connectapi.

Copy link
Collaborator

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this (also thank you for adding this!).

It's probably NBD either way, but I bet weekly would cover us well enough and save some electrons. But these tests aren't huge (they run on every PR anyway!) nightly is probably just fine.

@karawoo
Copy link
Collaborator Author

karawoo commented Mar 6, 2026

I'm good with this (also thank you for adding this!).

It's probably NBD either way, but I bet weekly would cover us well enough and save some electrons. But these tests aren't huge (they run on every PR anyway!) nightly is probably just fine.

sounds good, updated to run weekly on Mondays

Copy link
Collaborator

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@jonkeane jonkeane merged commit 6bdb7e1 into main Mar 7, 2026
23 checks passed
@jonkeane jonkeane deleted the kara-nightly-integration-tests branch March 7, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants