Merged
Conversation
jonkeane
reviewed
Mar 6, 2026
Collaborator
jonkeane
left a comment
There was a problem hiding this comment.
I'm good with this (also thank you for adding this!).
It's probably NBD either way, but I bet weekly would cover us well enough and save some electrons. But these tests aren't huge (they run on every PR anyway!) nightly is probably just fine.
Collaborator
Author
sounds good, updated to run weekly on Mondays |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Runs integration tests on a nightly schedule in addition to on PRs. Since the integration tests include preview builds, this should help us catch cases when upcoming changes in Connect will break connectapi so we can quickly fix them.
Approach
Add a
scheduletrigger. If integration tests fail, we'll send a slack notification.Note I'm still waiting on a webhook so that part of things won't work yet until I get it and can create the appropriate repository secret.Checklist
NEWS.md(referencing the connected issue if necessary)?devtools::document()?connectapi.