Skip to content

update PR template#514

Merged
karawoo merged 6 commits intomainfrom
kara-safer-connect-releases
Mar 6, 2026
Merged

update PR template#514
karawoo merged 6 commits intomainfrom
kara-safer-connect-releases

Conversation

@karawoo
Copy link
Collaborator

@karawoo karawoo commented Mar 6, 2026

Intent

Reminds us to update the appropriate changelog if an upcoming release of Connect will break connectapi and require an update (as determined by the integration tests we run in CI)

Checklist

  • Does this change update NEWS.md (referencing the connected issue if necessary)?
  • Does this change need documentation? Have you run devtools::document()?

Co-authored-by: Jonathan Keane <jkeane@gmail.com>
@karawoo
Copy link
Collaborator Author

karawoo commented Mar 6, 2026

Hmm that spacing isn't quite right, now it renders like this

image

will try to fix

edit: that was the wrong screenshot, the original one. without the bullet it was being added to the parent bullet. blah, anyway, markdown is silly

@karawoo
Copy link
Collaborator Author

karawoo commented Mar 6, 2026

@jonkeane I tried indenting with 2, 4, 6, and 8 spaces but nothing is getting the sub-item on its own line without a sub-bullet. Why don't I just make this a single item, that's easy and avoids the lonely sub-bullet.

@jonkeane
Copy link
Collaborator

jonkeane commented Mar 6, 2026

Why don't I just make this a single item, that's easy and avoids the lonely sub-bullet.

💯

@karawoo karawoo merged commit 66c25b7 into main Mar 6, 2026
22 checks passed
@karawoo karawoo deleted the kara-safer-connect-releases branch March 6, 2026 21:58
@github-actions github-actions bot restored the kara-safer-connect-releases branch March 6, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants