Conversation
|
Do we want to target a different branch that will act as more of a "staging" branch for wrap 0.2? I think
|
Niraj-Kamdar
left a comment
There was a problem hiding this comment.
I have left some comments.
| { | ||
| uri: "lib2", | ||
| type: "wasm", | ||
| id: "0", |
There was a problem hiding this comment.
What if we use IPFS hash of the abi as id?
It's guaranteed to be unique and since content addressable no need to embed the imported abi.
There was a problem hiding this comment.
The goal of the "id" is to be a (1) small in size & (2) efficient to lookup (i.e. strcmp). The URI does not satisfy these things in my opinion.
There was a problem hiding this comment.
I believe it has its own benefits as I discussed and we should compare both and see which is a better way going forward.
|
Responded @Niraj-Kamdar, would you feel comfortable approving in its current state? |
This PR includes: