fix: update vm-base-rs global deps#1491
Merged
dOrgJelli merged 1 commit intoorigin-devfrom Feb 3, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to install clang as a global dependency within the rust base image, so that building/linking native c libraries can be done within builds. One example of this is within the substrate wrapper: https://github.com/polywrap/integrations/tree/main/protocol/substrate/rpc-wrapper
These dependencies used to exist, but were removed here: #1485
This lead to an error when building the the substrate wrapper, which this PR fixes.
I've already republished the
polywrap/vm-base-rs:latesttag, but we still need to:0.9.5, which implements the same CPU-arch + version selection logic for the build images, which has been added to0.10.0in the PR above. This will ensure that changes to thelatesttag do not modify behavior for0.9users.