dunstctl: script, module & preview images#362
Open
aidenlangley wants to merge 8 commits intopolybar:masterfrom
Open
dunstctl: script, module & preview images#362aidenlangley wants to merge 8 commits intopolybar:masterfrom
aidenlangley wants to merge 8 commits intopolybar:masterfrom
Conversation
x70b1
reviewed
Jan 18, 2022
Member
x70b1
left a comment
There was a problem hiding this comment.
Thanks for this!
Would you like to change the scripts so that they are not shell specific?
Author
|
Sure, can include a sh version, will push it shortly. |
emanuele6
suggested changes
Jan 23, 2022
Co-authored-by: Emanuele Torre <torreemanuele6@gmail.com>
Member
|
What about removing the fish version? |
|
Thanks for that amazing script, But I noticed that the show-all not working with me because i wasn't having the jq package, just hilight that in the README. |
Author
Why? |
Member
|
To not have to maintain 2 versions of the script. |
Author
|
I'd prefer to keep them both, it's a good foundation for others to build on if they'd like to learn, and realistically, the scripts will not change often, and it's not that difficult to maintain them both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.