Skip to content

Prepare tab for cache management #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
btry wants to merge 1 commit into
base: develop
Choose a base branch
from
+26 −9
Open

Prepare tab for cache management #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/CronTask.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,19 +70,19 @@ public static function displayTabContentForItem(CommonGLPI $item, $tabnum = 1, $
if ($item instanceof GlpiCronTask) {
/** @var GlpiCronTask $item */
$cron_task = new self();
$cron_task->showForCronTask($item);
$cron_task->showForCronTask($item, $tabnum);
}
return true;
}

public function showForCronTask(CommonDBTM $item)
public function showForCronTask(CommonDBTM $item, int $tabnum)
{
$itemtype = $item->fields['itemtype'];
if (!in_array($itemtype, CronTaskProvider::getCronTaskTypes())) {
return;
}
$crontask = new $itemtype();
$crontask->showForCronTask($item);
$crontask->showForCronTask($item, $tabnum);
}

/**
Expand Down
19 changes: 15 additions & 4 deletions src/DataSource/AbstractCronTask.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,16 +50,27 @@ abstract class AbstractCronTask extends CommonGLPI implements CronTaskInterface

protected static string $downloadMethod;

protected const TAB_DIAGNOSIS = 0;
protected const TAB_CACHE = 1;


public function getTabNameForItem(CommonGLPI $item, $withtemplate = 0)
{
return '';
}

public function showForCronTask(CommonDBTM $item)
public function showForCronTask(CommonDBTM $item, int $tabnum)
{
switch ($item->fields['name']) {
case static::$downloadMethod:
$this->showGapsReport();
if ($tabnum === self::TAB_DIAGNOSIS) {
switch ($item->fields['name']) {
case static::$downloadMethod:
$this->showGapsReport();
}
} elseif ($tabnum === self::TAB_CACHE) {
switch ($item->fields['name']) {
case static::$downloadMethod:
// TODO: implement tab to clear cached data in files/ folder
}
}
}

Expand Down
5 changes: 4 additions & 1 deletion src/DataSource/CarbonIntensity/ElectricityMaps/CronTask.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,10 @@ public static function getIcon()

public function getTabNameForItem(CommonGLPI $item, $withtemplate = 0)
{
return self::createTabEntry(__('Resource diagnosis', 'carbon'), 0);
return [
self::TAB_DIAGNOSIS => self::createTabEntry(__('Resource diagnosis', 'carbon'), 0),
// self::TAB_CACHE => self::createTabEntry(__('Cache', 'carbon'), 0),
];
}

public static function enumerateTasks(): array
Expand Down
5 changes: 4 additions & 1 deletion src/DataSource/CarbonIntensity/Rte/CronTask.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,10 @@ public static function getIcon()

public function getTabNameForItem(CommonGLPI $item, $withtemplate = 0)
{
return self::createTabEntry(__('Resource diagnosis', 'carbon'), 0);
return [
self::TAB_DIAGNOSIS => self::createTabEntry(__('Resource diagnosis', 'carbon'), 0),
// self::TAB_CACHE => self::createTabEntry(__('Cache', 'carbon'), 0),
];
}

public static function enumerateTasks(): array
Expand Down