fix: title text cannot be edited for multiple plots/components (regression since v3.0.0)#7513
Merged
emilykl merged 4 commits intoplotly:masterfrom Oct 7, 2025
Conversation
Thanks to the jasmine test, I realized that I changed the wrong line.
Contributor
Author
|
No ideas why the https://github.com/plotly/plotly.js/blob/bddbb149ba2ffe5baf310867ef6cf3c27af65d6a/test/jasmine/tests/transition_test.js fails. plotly.js/test/jasmine/tests/transition_test.js Lines 646 to 652 in bddbb14 I found that the increased delay time in #7343 is not long enough (I have no idea why it doesn't work in my case, as I haven't changed the transition logic I think). After increasing the delay time from However, this is unreliable in the GitHub workflow! The delay may need to be increased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression since v3.0.0 (#7212)
After introducing
title.text, some plots and components edit function breaks. This PR the issue. Also closes #7512 .Affected plots
aaxis.title.text,baxis.title.text, andcaxis.title.textradialaxis.title.textAffected components
title.textxaxis.title.text