Elaborate on custom bundle instructions#7101
Merged
archmoj merged 25 commits intoplotly:masterfrom Aug 13, 2024
Merged
Conversation
archmoj
reviewed
Aug 13, 2024
Co-authored-by: Mojtaba Samimi <33888540+archmoj@users.noreply.github.com>
Contributor
|
How about adding both install and clone options with some basic information of the advantages of each one? |
Contributor
Author
|
@archmoj , good catch! I've updated the instructions to include a version (tags) |
archmoj
reviewed
Aug 13, 2024
Contributor
Author
|
I made a note, to check the CONTRIBUTING.md list of prerequisites for node/npm version after the clone of a specific version, so that it'll be aligned. |
birkskyum
changed the title
archmoj
reviewed
Aug 13, 2024
birkskyum
changed the title
archmoj
reviewed
Aug 13, 2024
archmoj
reviewed
Aug 13, 2024
archmoj
reviewed
Aug 13, 2024
archmoj
reviewed
Aug 13, 2024
archmoj
reviewed
Aug 13, 2024
Co-authored-by: Mojtaba Samimi <33888540+archmoj@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For custom builds, it seems easier to just clone the repo, aligned with the contrib guide, instead of the somewhat atypical approach to npm installing it and go to the node_modules/plotly.js for making custom builds