Closed
Conversation
Collaborator
|
Nice! Maybe then just a test like this one but for cartesian? |
Contributor
Author
|
@alexcjohnson I don't recall what |
Collaborator
|
So looks like on CI it's ignored, but it marks tests that need to run so the noCI tests succeed. Quite possibly obsolete by now, you could try running just And good call, I somehow hadn't noticed the cartesian test right above that 😅 But that test was already passing, right? So what can we add to that test that would have broken before this change but now works correctly? |
Contributor
Author
|
Reworked in #7475. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6394.
@plotly/plotly_js