Conversation
- needed new `dash_ag_grid.useGridFilter` - needed api update for `filterChangedCallback` deprecation to `onModelChange` and whether or not it is empty to kill `isFilterActive`
gvwilson
added
feature
# Conflicts: # package-lock.json # package.json
| "ag-grid-community": "31.3.4", | ||
| "ag-grid-enterprise": "31.3.4", | ||
| "ag-grid-react": "31.3.4", | ||
| "ag-grid-community": "32.3.4", | ||
| "ag-grid-enterprise": "32.3.4", | ||
| "ag-grid-react": "32.3.4", |
There was a problem hiding this comment.
Is retaining the minor and patch versions deliberate? do we want to just update to the latest minor/patch versions?
There was a problem hiding this comment.
Yes, we didnt want things to randomly get out of sync.
| export const defaultProps = DashAgGrid.defaultProps; | ||
|
|
||
| var dagfuncs = (window.dash_ag_grid = window.dash_ag_grid || {}); | ||
| dagfuncs.useGridFilter = useGridFilter; |
There was a problem hiding this comment.
A way to pass the internal api things to the app developer. For example, this passes useGridFilter to be used in the difference of useImperativeHandler between 31 and 32. This way they can use filters like they were the component developer.
|
@T4rk1n could you give this a look? |
package.json
Outdated
| "last 7 years and not dead" | ||
| ] | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
nitpick: missing endline at end of file.
src/lib/components/AgGrid.react.js
Outdated
| export const propTypes = DashAgGrid.propTypes; | ||
| export const defaultProps = DashAgGrid.defaultProps; | ||
|
|
||
| DashAgGrid.dashRenderType = true; |
There was a problem hiding this comment.
I think you could also have added it as a static property on the class.
4 participants
No description provided.