-
-
Notifications
You must be signed in to change notification settings - Fork 60
Fix RTD build now that the URL for 6.2-latest is now 6.2-dev #591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@stevepiercy thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
Uh-oh, looks like there's other unrelated issues that cause CI checks to fail. Can someone else add to this PR or fix those separately? I have no clue. |
|
FWIW, here are all latest symlinks: (FTR, I noticed that 3-latest was pointing to 3.3.5 instead of 3.3.6, so I fixed that.) |
|
The test error is this This may be caused by having switched to native namespaces, which we did a few days ago in PR #588. But the tests were green there. I can't check now. Maybe @gforcada or @davisagli see what we are missing. |
|
Initially in d0b0183 the file This is blocking CI for |
|
@mauritsvanrees There are at least 3 problems which are preventing the PEP 420 namespaces from working correctly.
@petschki could we have an alpha release of plone.staticresources please?
I opened a PR plone/plone.browserlayer#41
|
|
@davisagli I've released |
|
This is strange. It goes against what I have seen during testing the past months and what I have written in the zc.buildout readme: pip can handle a mix of namespace styles in final releases plus one style in editable installs. I wonder what has changed in the days between merging the PR here that added native namespaces and now. |
|
I have released I have updated the other constraints/versions on 6.2-dev as well now, including |
mauritsvanrees
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is green now.
Co-authored-by: Maurits van Rees <maurits@py76.be>
@mauritsvanrees The issue isn't really pip but how the namespace module's |
The rename of the URL broke documentation test and RTD PR preview builds once I updated the git submodule in documentation. This should fix it.
See:
📚 Documentation preview 📚: https://ploneapi--591.org.readthedocs.build/