Revert "Handle Twirl format() -> $twirl__format rename in pekko-grpc templates"#775
Draft
mkurz wants to merge 1 commit intoplayframework:mainfrom
Draft
Revert "Handle Twirl format() -> $twirl__format rename in pekko-grpc templates"#775mkurz wants to merge 1 commit intoplayframework:mainfrom
format() -> $twirl__format rename in pekko-grpc templates"#775mkurz wants to merge 1 commit intoplayframework:mainfrom
Conversation
…templates" This reverts commit b3a34bc.
mkurz
changed the title
format() -> $twirl__format rename in pekko-grpc templates"
Member
Author
|
(btw: same workaround is needed for akka-grpc) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit b3a34bc.
Can be merged as soon as pekko-grpc upgrades twirl to (as of today unreleased) 2.1.0 or newer.
Workaround is needed for playframework/twirl#1097